Pin baseview to fork with sRGB workaround#251
Open
john-parton wants to merge 1 commit into
Open
Conversation
Update baseview dependency to use john-parton/baseview bugfix/srgb-not-supported branch. Added workspace-level patch to ensure all crates (including vizia) use the same baseview fork.
|
Hey just commenting here, as we know Robbert hasn't been maintaining NIH-plug very much, which is why the "maintenance mode" disclaimer thingy in the README has been there, but somehow I never noticed that there's a seemingly actively maintained fork linked in the same disclaimer Check it out https://codeberg.org/BillyDM/nih-plug It seems this fork is already using a newer version of baseview that has your fixes applied, so at least for the NIH-plug framework this PR isn't really necessary anymore? Worth mentioning that the fork sadly doesn't include the cool plugins like Spectral Compressor, the repo is dedicated purely to the framework |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempt to fix #250
Update baseview dependency to use john-parton/baseview bugfix/srgb-not-supported branch. Added workspace-level patch to ensure all crates (including vizia) use the same baseview fork.
I have also provided the patch to upstream: RustAudio/baseview#221