Skip to content

Conversation

@ilya-epifanov
Copy link

No description provided.

@ilya-epifanov ilya-epifanov changed the title update to the latest iced_baseview (iced 0.10) [WIP] update to the latest iced_baseview (iced 0.10) Feb 11, 2024

[dev-dependencies]
nih_plug = { path = ".." }
nih_plug = { path = "..", default-features = false }
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise it's impossible to opt out of default features in a binary

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch.

@ilya-epifanov
Copy link
Author

@robbert-vdh I'd like some input from you on this PR.
The only thing missing now is the generic UI. (I've commented these modules out in https://github.com/robbert-vdh/nih-plug/pull/112/files#diff-161f460a822a8c7d70bcbdaa33da6c90b9dff1babb3835c15689aa81d66b2883R10)
The rest works just fine for me. I've tested it in Bitwig on Linux and Windows for now

Copy link
Owner

@robbert-vdh robbert-vdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for working on this! I spent a couple hours doing this a couple months ago, and then promptly stopped when I got frustrated with the whole architecture halfway through porting ParamSlider.

I'll borrow the resolver and default features changes on the master branch right now. Take your time finishing this PR. Or if someone else wants to chip in, feel free!

repository = "https://github.com/robbert-vdh/nih-plug"

[workspace]
resolver = "2"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice drive by fix! Meant to add this for a while (would be nice if it was inferred from the edition of the workspace members) but I kept forgetting about it.


[dev-dependencies]
nih_plug = { path = ".." }
nih_plug = { path = "..", default-features = false }
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch.

#[cfg(not(feature = "opengl"))]
gl_config: None,
// #[cfg(not(feature = "opengl"))]
// gl_config: None,
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is not needed anymore then the whole section including the comment can be removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants