docs(ci): say why fold is push-only too, and name the fork case - #1222
Open
munkhorgil wants to merge 1 commit into
Open
docs(ci): say why fold is push-only too, and name the fork case#1222munkhorgil wants to merge 1 commit into
munkhorgil wants to merge 1 commit into
Conversation
Review note on the alarm fix: `stalled` gained a long comment explaining the push-only filter and `fold` gained the same condition with none, so the two gates documented themselves unequally. `fold` now says why as well - briefly, pointing at `stalled` rather than restating it, because the consequence differs: there the second run pages somebody, here it only ever wasted a clone and a token mint to discover `main already contains next`. Also records the one case `event == 'push'` excludes that is not a blank run: a FORK pull request whose head branch is itself named `next` would match `branches: [next]`, and Stainless's guard is `push || fork`, so its jobs would really execute. `next` is an internal release branch and these repositories take no external contributions, so that run does not exist today. Noted rather than handled, so the next person weighing an external-contribution change finds it already written down instead of rediscovering it. Comments only; both `if:` conditions are unchanged. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
Claude finished @munkhorgil's task in 1m 22s —— View job Review complete
Code Review Summary
Baseline usedThis repo has no Stainless-generated commits touching CI workflow files — Parity differencesNone — confirmed by diff inspection: the Correctness check of the added comments
Blocking findingsNone. Other notes
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Comment-only follow-up to #1221, which merged before review notes landed. Opened here so this repo and
sdk-roark-analytics-python(roarkhq/sdk-roark-analytics-python#523) keep an identicalfold-next-into-main.yml.Two review notes from the python side
1. The two gates documented themselves unequally. #1221 gave
stalleda long comment explaining the push-only filter, and gavefoldthe same condition with no explanation — its comment still only said "only fold when CI actually passed onnext".foldnow says why as well, briefly, pointing atstalledrather than restating it. The consequence genuinely differs: onstalledthe second run pages somebody, whereas onfoldit only ever wasted a clone and a token mint to discovermain already contains next.2. The one excluded case that is not a blank run.
event == 'push'would also filter a fork pull request whose head branch is itself namednext— that matchesbranches: [next], and Stainless's guard ispush || fork, so its jobs would really execute.nextis an internal release branch and these repositories take no external contributions, so that run does not exist today. Recorded rather than handled, so whoever weighs an external-contribution change finds it already written down instead of rediscovering it.Scope
Comments only. Both
if:conditions are byte-identical to what merged in #1221;git difftouches nothing but comment lines. YAML re-parsed.🤖 Generated with Claude Code