Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor pgp::mpi to use std::vector instead of fixed-size buffer. #2338

Merged
merged 1 commit into from
Apr 9, 2025

Conversation

ni4
Copy link
Contributor

@ni4 ni4 commented Apr 5, 2025

Less memory usage, more robust, cleaner code.

@ni4 ni4 force-pushed the ni4-refactor-pgp-mpi branch from 908b279 to 62854cf Compare April 5, 2025 10:05
Copy link

codecov bot commented Apr 5, 2025

Codecov Report

Attention: Patch coverage is 96.63300% with 10 lines in your changes missing coverage. Please review.

Project coverage is 85.33%. Comparing base (ccbd02e) to head (1033e23).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
src/lib/crypto/mpi.cpp 92.30% 2 Missing ⚠️
src/lib/crypto/ossl_utils.hpp 60.00% 2 Missing ⚠️
src/lib/crypto/rsa.cpp 87.50% 2 Missing ⚠️
src/lib/crypto/botan_utils.hpp 83.33% 1 Missing ⚠️
src/lib/crypto/ecdsa.cpp 90.90% 1 Missing ⚠️
src/lib/crypto/rsa_ossl.cpp 93.75% 1 Missing ⚠️
src/lib/crypto/sm2.cpp 95.23% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2338      +/-   ##
==========================================
+ Coverage   85.27%   85.33%   +0.06%     
==========================================
  Files         125      125              
  Lines       22814    22841      +27     
==========================================
+ Hits        19454    19491      +37     
+ Misses       3360     3350      -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ni4 ni4 force-pushed the ni4-refactor-pgp-mpi branch from 62854cf to 1033e23 Compare April 5, 2025 11:20
@ni4 ni4 requested review from ronaldtse, maxirmx and desvxx April 6, 2025 09:16
@ni4 ni4 marked this pull request as ready for review April 6, 2025 09:16
Copy link
Member

@maxirmx maxirmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maxirmx maxirmx merged commit 716c78e into main Apr 9, 2025
136 of 137 checks passed
@maxirmx
Copy link
Member

maxirmx commented Apr 9, 2025

Merging with two approvals

@maxirmx maxirmx deleted the ni4-refactor-pgp-mpi branch April 9, 2025 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants