Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support dearmoring of gpg-armored files #2336

Merged
merged 2 commits into from
Apr 7, 2025
Merged

Conversation

ni4
Copy link
Contributor

@ni4 ni4 commented Apr 1, 2025

...and refactor some surrounding dearmoring code.

Fixes #1049

@ni4 ni4 force-pushed the ni4-1049-support-gpg-enarmor branch from 688b9a4 to 1313816 Compare April 1, 2025 14:24
Copy link

codecov bot commented Apr 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.28%. Comparing base (ccbd02e) to head (1313816).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2336      +/-   ##
==========================================
+ Coverage   85.27%   85.28%   +0.01%     
==========================================
  Files         125      125              
  Lines       22814    22782      -32     
==========================================
- Hits        19454    19429      -25     
+ Misses       3360     3353       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ni4 ni4 marked this pull request as ready for review April 1, 2025 15:25
@ni4 ni4 requested review from ronaldtse, maxirmx and desvxx April 1, 2025 15:35
Copy link
Member

@maxirmx maxirmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ni4
Copy link
Contributor Author

ni4 commented Apr 7, 2025

Merging with two approvals. Thanks all!

@ni4 ni4 merged commit a9863bb into main Apr 7, 2025
122 checks passed
@ni4 ni4 deleted the ni4-1049-support-gpg-enarmor branch April 7, 2025 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow to dearmor files, armored with gpg --enarmor
3 participants