Closed
Conversation
…p and download intochroot
rlmenge
commented
Sep 21, 2022
| } | ||
|
|
||
| // removeDuplicateStrings will remove duplicate entries from a string slice | ||
| func removeDuplicateStrings(packList []string) (deduplicatedPackList []string) { |
Owner
Author
There was a problem hiding this comment.
Could be made a library function
rlmenge
commented
Sep 21, 2022
|
|
||
| // parsePackListFile will parse a list of packages to pack if one is specified. | ||
| // Duplicate list entries in the file will be removed. | ||
| func parsePackListFile(packListFile string) (packList []string, err error) { |
Owner
Author
There was a problem hiding this comment.
Could be made a library function
rlmenge
commented
Sep 21, 2022
|
|
||
| // findSPECFiles finds all SPEC files that should be considered for packing. | ||
| // Takes into consideration a packList if provided. | ||
| func findSPECFiles(specsDir string, packList []string) (specFiles []string, err error) { |
Owner
Author
There was a problem hiding this comment.
Could be made a library function
PawelWMS
reviewed
Oct 5, 2022
Comment on lines
+119
to
+123
| // This is on in srpmpacker. However, this prevents empty lists | ||
| // if len(packList) == 0 { | ||
| // err = fmt.Errorf("cannot have empty pack list (%s)", packListFile) | ||
| // } | ||
|
|
There was a problem hiding this comment.
Suggested change
| // This is on in srpmpacker. However, this prevents empty lists | |
| // if len(packList) == 0 { | |
| // err = fmt.Errorf("cannot have empty pack list (%s)", packListFile) | |
| // } |
12 tasks
Owner
Author
|
stale closing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge Checklist
All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)
*-staticsubpackages, etc.) have had theirReleasetag incremented../cgmanifest.json,./toolkit/tools/cgmanifest.json,./toolkit/scripts/toolchain/cgmanifest.json,.github/workflows/cgmanifest.json)./SPECS/LICENSES-AND-NOTICES/data/licenses.json,./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md,./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)*.signatures.jsonfilessudo make go-tidy-allandsudo make go-test-coveragepassSummary
Fix quickstart and the srpm download command
https://microsoft.visualstudio.com/OS/_sprints/taskboard/ft_iot_Mariner/OS/2209?workitem=40942962
//TO DO
// ADD TLS certs for srpm servers that need them
// Bug in SRPM_URL_LIST where setting the URL to use 1.0 still curls a .cm2 srpm (fails when same cmd runs outside of toolkit)
// Bug where the SRPM_PACK_LIST= will not clear srpm_pack_list_file ($(BUILD_SRPMS_DIR)/pack_list.txt) even if argument is empty
// A lot of code duplication w/ srpmpacker. Should make a library
Change Log
Does this affect the toolchain?
YES/NO
Associated issues
Links to CVEs
Test Methodology