Skip to content

Conversation

@craff
Copy link
Collaborator

@craff craff commented Jul 5, 2024

No description provided.

@craff craff requested a review from rlepigre July 5, 2024 18:45
(dune :build)
(timed (and (>= 1.0) :with-test))
(pacomb (and (>= 1.1) :with-test))
(hashcons :with-test)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably add a version bound.

Suggested change
(hashcons :with-test)
(hashcons (and (>= 1.4.0) :with-test))

@rlepigre rlepigre self-assigned this Jul 5, 2024
Copy link
Owner

@rlepigre rlepigre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, it is fine to add dependencies as long as they are identified as only for tests in the opam file. We might need to tweak CI though before we merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants