-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add AnalyzerUtilities to NuGet package #326
Add AnalyzerUtilities to NuGet package #326
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot wasn't able to review any files in this pull request.
Files not reviewed (2)
- src/Analyzers/Moq.Analyzers.csproj: Language not supported
- tests/Moq.Analyzers.Test/PackageTests.Baseline#contents.verified.txt: Language not supported
📝 WalkthroughWalkthroughThe pull request modifies the Changes
Possibly related PRs
Suggested Labels
Suggested Reviewers
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (2)
⏰ Context from checks skipped due to timeout of 90000ms (3)
🔇 Additional comments (3)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Code Climate has analyzed commit 90137b5 and detected 0 issues on this pull request. View more on Code Climate. |
This fixes a regression caused by #290. `Microsoft.CodeAnalysis.AnalyzerUtilities` is not one of the assemblies provided by the host (i.e. compiler), so we need to include it in our own package. I'm not sure how to write an automated test for this. Our current tests don't use the NuGet package. Doing something like `dotnet format` in theory should work, but when I tried that it passed even without this change. This does result in a new package contents baseline, so we can chalk this one up to reviewer error and revisit if we find a better solution.
This fixes a regression caused by #290.
Microsoft.CodeAnalysis.AnalyzerUtilities
is not one of the assemblies provided by the host (i.e. compiler), so we need to include it in our own package.I'm not sure how to write an automated test for this. Our current tests don't use the NuGet package. Doing something like
dotnet format
in theory should work, but when I tried that it passed even without this change.This does result in a new package contents baseline, so we can chalk this one up to reviewer error and revisit if we find a better solution.