Improved support for space-containing file paths #514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
rjkroege
commented
Feb 11, 2025
rjkroege
commented
- Add a better E
- remove unnecessary named return value
- Remove superfluous assignments
- Refactoring for better file-with-spaces handling
- Robustness improvement in file name expansion
- Added some code to provide better debugging support.
- Fix bug in opening file whose names contains spaces
- Support setting names from the filesystem that have spaces
rjkroege
force-pushed
the
E_with_spaces_upstream
branch
from
c17f678 to
a346989
Compare
Plan9 port comes with a command E. E is a shell script that opens a file for editing and blocks until one closes it in Acme/Edwood. P9P E does not work for files whose names contain spaces. So this CL adds a new E implementation in Go that should support file names containing spaces. It doesn't yet do so because of bugs in Edwood. Also updated go.mod for E commandt ake sure that the go.mod and go.sum are correct for the deps needed. Also updated the code for the new version of staticcheck.
Partial work to improve how Edwood handles files whose names contain spaces.
The code to open files whose names contain spaces had an off-by-1 error and didn't work when right-clicking a selection including quotes. Fix this.
With this change, the E command landed earlier will work for files whose names contain spaces as the change permits setting file paths to contain spaces.
rjkroege
force-pushed
the
E_with_spaces_upstream
branch
from
a346989 to
384fce8
Compare
|
🎊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.