Fix 470: missing chords #511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prepare for later bug fixes by starting to separate the code in exec.go:/execute into more easily testable components.
Prepare to fix a bug by further refactorings in exec.go: make lookup parametrizable.
Refactor exec.go/exect to fix chord reporting bug. Note: it would appear from this change that a tiny change (setting r to not empty in delegateExection) is all that was required to actually fix the bug but wait for a subsequent CL that contains unit tests.
rjkroege
force-pushed
the
missing_chord_470-2
branch
from
f6875f1 to
791d41e
Compare
Add a test that shows that Edwood provides an event stream that more closely matches Acme. Fixes #470.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prepare for later bug fixes by starting to separate the code in
exec.go:/execute into more easily testable components.