Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add text descriptions for asm.cpu values in ARM architecture plugin #4809

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

kavin-t28
Copy link

@kavin-t28 kavin-t28 commented Dec 31, 2024

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository
  • I made sure to follow the project's coding style
  • I've documented or updated the documentation of every function and struct this PR changes. If not so I've explained why.
  • I've added tests that prove my fix is effective or that my feature works (if possible)
  • I've updated the rizin book with the relevant information (if needed)

Detailed description

This pull request adds text descriptions for each asm.cpu value in the ARM architecture plugin. This enhancement will help users, especially those who are not familiar with less common architectures, to understand the asm.cpu values better.

Test plan

  1. Verify that the descriptions for asm.cpu values are correctly added in the arm_cpus array.
  2. Ensure that the descriptions are displayed correctly when querying asm.cpu values.
  3. Run the existing tests to ensure no functionality is broken.

Closing issues

closes #XXXX

Copy link
Member

@XVilka XVilka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this? Have you even tried? It will not work.

@kavin-t28
Copy link
Author

I tried to do it from my understanding , please guide me if i have done something wrong

Copy link
Member

@wargio wargio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry, but explain us how this should work (by your logic)? it's like you thrown random text in a file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants