Let update-mod-version take a PACKAGE_PREFIX env var
#808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandur
force-pushed
the
brandur-package-prefix
branch
from
44c3807 to
3c5d19c
Compare
bgentry
approved these changes
Mar 17, 2025
Comment on lines
30
to
32
| // Allows secondary River repositories to make use of this command by | ||
| // specifying their own prefix. | ||
| packagePrefix := cmp.Or(os.Getenv("PACKAGE_PREFIX"), "github.com/riverqueue/river") |
There was a problem hiding this comment.
Could just make this a required input and skip having a default value? Your call.
There was a problem hiding this comment.
Yeah, good point. Can't hurt to be explicit about this. Updated the command and added PATH_PREFIX in this project's Makefile.
brandur
force-pushed
the
brandur-package-prefix
branch
from
3c5d19c to
57749a2
Compare
Here, have `update-mod-version` take a `PACKAGE_PREFIX` env var that dictates which prefix it'll operate on, defaulting the previous behavior of `github.com/riverqueue/river`. The idea here is that we should be able to use reuse this command from other River repositories like `rivercontrib` to update internal cross dependencies.
brandur
force-pushed
the
brandur-package-prefix
branch
from
57749a2 to
0310ef8
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here, have
update-mod-versiontake aPACKAGE_PREFIXenv var thatdictates which prefix it'll operate on, defaulting the previous behavior
of
github.com/riverqueue/river.The idea here is that we should be able to use reuse this command from
other River repositories like
rivercontribto update internal crossdependencies.