feat: upgrade ruff pre-commit hook to v0.15.1 and general to v6#29
feat: upgrade ruff pre-commit hook to v0.15.1 and general to v6#29newtob wants to merge 4 commits intoritwiktiwari:mainfrom
Conversation
|
@newtob thanks for bumping up the versions! Could you also take a look at why tests are failing? |
|
Hi, I think the following needs to be run in advance of the test stage: I am absolutely loving Copier-Astral. It's very cool! Thanks, |
|
@newtob thanks again! I’ve fixed the filing tests. Once all checks are passing, please rebase your branch and we’ll get your PR merged. Thank you for your contributions. |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
template/{% if include_prek %}.pre-commit-config.yaml{% endif %}.jinja (1)
20-23: Consider updating hook id fromrufftoruff-check.The official Ruff documentation now uses
ruff-checkas the hook id withargs: [ --fix ]for the linter. Theruffhook id still works butruff-checkis the documented approach.♻️ Proposed update to align with official documentation
- repo: https://github.com/astral-sh/ruff-pre-commit rev: v0.15.1 hooks: - - id: ruff + - id: ruff-check args: [--fix] - id: ruff-format🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@template/`{% if include_prek %}.pre-commit-config.yaml{% endif %}.jinja around lines 20 - 23, Update the pre-commit hook id from "ruff" to the documented "ruff-check" while keeping the existing args: [--fix]; locate the hooks block that currently lists "- id: ruff" and change that identifier to "- id: ruff-check" (leave the "- id: ruff-format" entry as-is).
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@template/`{% if include_prek %}.pre-commit-config.yaml{% endif %}.jinja:
- Around line 20-23: Update the pre-commit hook id from "ruff" to the documented
"ruff-check" while keeping the existing args: [--fix]; locate the hooks block
that currently lists "- id: ruff" and change that identifier to "- id:
ruff-check" (leave the "- id: ruff-format" entry as-is).
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
💤 Files with no reviewable changes (1)
📝 WalkthroughWalkthroughThis PR contains minimal cosmetic and dependency updates: removal of extraneous blank lines in CI workflow configuration and version bumps for pre-commit hook dependencies to their latest releases. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~5 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment Tip You can disable the changed files summary in the walkthrough.Disable the |
Upgraded two pre-commit hooks
https://github.com/pre-commit/pre-commit-hooks/releases
Summary by CodeRabbit