fix: unify password validation across Signup, ForgotPassword and ResetPassword - #2034
Conversation
|
@Aryanbansal-05 is attempting to deploy a commit to the ritesh Team on Vercel. A member of the Team first needs to authorize it. |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Hi @Aryanbansal-05! Thanks for the contribution. I have triaged your PR and set it to merge into the
Welcome to the HELPDESK.AI developer family! 🚀💻 |
|
Superb implementation, @Aryanbansal-05! I've successfully resolved all conflicts in your PR and queued it for merging into
Keep up the outstanding work! Let's build together! 🔥 |
|
Hi @Aryanbansal-05! Thanks for the contribution. I have triaged your PR and set it to merge into the
Welcome to the HELPDESK.AI developer family! 🚀💻 |
1 similar comment
|
Hi @Aryanbansal-05! Thanks for the contribution. I have triaged your PR and set it to merge into the
Welcome to the HELPDESK.AI developer family! 🚀💻 |
|
Superb implementation, @Aryanbansal-05! I've successfully resolved all conflicts in your PR and queued it for merging into
Keep up the outstanding work! Let's build together! 🔥 |
15c036e
into
riteshbonthalakoti:gssoc
…tPassword
🔐 Summary
Resolves #1976 by standardizing password validation rules across all three authentication flows — Signup, ForgotPassword, and ResetPassword.
🛠️ Changes Made
1.
Frontend/src/utils/validatePassword.js— New Shared UtilityCreated a reusable
validatePasswordfunction enforcing:2.
Frontend/src/pages/ForgotPassword.jsxvalidatePasswordutilitylength < 6tolength < 83.
Frontend/src/pages/ResetPassword.jsxvalidatePasswordutility4.
Frontend/src/pages/Signup.jsxpasswordRulesfrom{ minLength: 6 }to{ minLength: 8, requireUppercase: true, requireNumber: true }getPasswordValidationenforces the same complexity as other flows🛡️ Security Issues Fixed
Closes #1976