Fix u32 underflow in Unix timestamp calculation #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cast raw_secs and SNTP_TIME_OFFSET to i64 before subtraction to prevent u32 underflow panic when raw_secs < SNTP_TIME_OFFSET (e.g. dates before 1970 in NTP epoch). Closes risoflora#10
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
get_unix_time_by_addr()performed(raw_secs - SNTP_TIME_OFFSET) as i64where both operands areu32. Ifraw_secs < SNTP_TIME_OFFSET(e.g. dates before 1970 in NTP epoch), this causes a u32 underflow panic in debug mode or wraps silently in release mode. Fixed by casting both operands toi64before subtraction.Closes #10
Test plan
cargo checkpassescargo test— all tests pass