lib: perf: fix potential memory leaks #72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
00xc
commented
Nov 24, 2025
00xc
commented
- Clean up the fastchannel region when the performance service group is destroyed.
- Clean up previous allocations if something goes wrong during service group creation.
fc_memory_region is allocated in rpmi_service_group_perf_create(), so do not forget to free it in rpmi_service_group_perf_destroy(). Signed-off-by: Carlos López <[email protected]>
Do not forget to clean up previous allocations if something fails during in rpmi_service_group_perf_create(). Signed-off-by: Carlos López <[email protected]>
Correct the error message when the fastchannel region cannot be allocated by properly stating what happened. Signed-off-by: Carlos López <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.