Update snitch/location config selection #781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CASSANDA-19488 deprecates IEndpointSnitch and replaces it with InitialLocationProvider and NodeProximity classes. In Cassandra, the default yaml config retains the endpoint_snitch setting, whereas the alternative cassandra_latest yaml specifies the new options. CCM injects PropertyFileSnitch into config for multi datacenter clusters, but this is problematic as the old and new config options are mutually exclusive. This patch injects both the old and new settings into config when the cluster is populated, then removes whichever one was not present in the original yaml once it has been loaded. This allows dtests to run with both the legacy and latest configs and exercises both code paths.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CASSANDA-19488 deprecates IEndpointSnitch and replaces it with InitialLocationProvider and NodeProximity classes. In Cassandra, the default yaml config retains the endpoint_snitch setting, whereas the alternative cassandra_latest yaml specifies the new options. CCM injects PropertyFileSnitch into config for multi datacenter clusters, but this is problematic as the old and new config options are mutually exclusive.
This patch injects both the old and new settings into config when the cluster is populated, then removes whichever one was not present in the original yaml once it has been loaded. This allows dtests to run with both the legacy and latest configs and exercises both code paths.