Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #670: also decode empty stdout and stderr to strings #671

Merged
merged 1 commit into from
Apr 12, 2018

Conversation

ptbannister
Copy link
Contributor

Addresses Issue #670 to decode empty bytes objects (b'') for stdout and stderr piped from subprocess. Without this change, handle_external_tool_process returns inconsistently typed results - it returns stdout and stderr as strings if they're non-empty, but as bytes if they're empty.

@ptnapoleon ptnapoleon merged commit efbe572 into riptano:cassandra-test Apr 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants