fix scrollToPage bug, for SegmentedView and SegmentedBarExample

rilyu · May 9, 2017 · ea8a57f · ea8a57f
1 parent f6544c1
commit ea8a57f
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 10 deletions.
diff --git a/components/SegmentedView/SegmentedView.js b/components/SegmentedView/SegmentedView.js
@@ -76,17 +76,13 @@ export default class SegmentedView extends Component {
     if (index == this.state.activeIndex) return;
     this.setState({activeIndex: index}, () => {
       if (this.refs.carousel) {
-        this._ignoreCarouselChange = setTimeout(() => {
-          this._ignoreCarouselChange = null;
-        }, 300);
-        this.refs.carousel.scrollToPage(index);
+        this.refs.carousel.scrollToPage(index, false);
       }
       this.props.onChange && this.props.onChange(index);
     });
   }
 
   onCarouselChange(index) {
-    if (this._ignoreCarouselChange) return;
     this.setState({activeIndex: index}, () => {
       this.props.onChange && this.props.onChange(index);
     });

diff --git a/example/views/SegmentedBarExample.js b/example/views/SegmentedBarExample.js
@@ -57,16 +57,12 @@ export default class SegmentedBarExample extends NavigationPage {
     if (index != this.state.activeIndex) {
       this.setState({activeIndex: index});
       if (this.refs.carousel) {
-        this._ignoreCarouselChange = setTimeout(() => {
-          this._ignoreCarouselChange = null;
-        }, 300);
-        this.refs.carousel.scrollToPage(index);
+        this.refs.carousel.scrollToPage(index, false);
       }
     }
   }
 
   onCarouselChange(index) {
-    if (this._ignoreCarouselChange) return;
     this.setState({activeIndex: index});
   }