Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add leaderboards to canvas #7055

Open
wants to merge 59 commits into
base: main
Choose a base branch
from
Open

Conversation

djbarnwal
Copy link
Member

@djbarnwal djbarnwal commented Apr 3, 2025

TODO

  • Add leaderboard icon

image

Checklist:

  • Covered by tests
  • Ran it and it works as intended
  • Reviewed the diff before requesting a review
  • Checked for unhandled edge cases
  • Linked the issues it closes
  • Checked if the docs need to be updated
  • Intend to cherry-pick into the release branch
  • I'm proud of this work!

@djbarnwal djbarnwal marked this pull request as ready for review April 9, 2025 09:04
@briangregoryholmes
Copy link
Contributor

Screenshot 2025-04-11 at 4 16 59 PM

Can you take a stab at removing this state when the Canvas first loads? You can reference what I did with the KPI component (getMetricsViewFromName returns an isLoading property). I think we should follow up in another PR with a refactor of how and when this validation happens.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants