Skip to content

Conversation

notmgsk
Copy link
Contributor

@notmgsk notmgsk commented Dec 16, 2020

Description

Perform Quil-T calibration expansion on the client. Optionally force calibration to occur on the translation service with expand_calibrations=False.

Checklist

  • The above description motivates these changes.
  • There is a unit test that covers these changes.
  • All new and existing tests pass locally and on Travis CI.
  • Parameters and return values have type hints with PEP 484 syntax.
  • Functions and classes have useful Sphinx-style docstrings.
  • All code follows Black style and obeys flake8 conventions.
  • (New Feature) The docs have been updated accordingly.
  • (Bugfix) The associated issue is referenced above using auto-close keywords.
  • The changelog is updated, including author and PR number (@username, gh-xxx).

@notmgsk notmgsk force-pushed the client-side-calibration-expansion branch from 040485e to 46658fb Compare December 16, 2020 20:04
@notmgsk notmgsk marked this pull request as ready for review December 16, 2020 20:06
@notmgsk notmgsk requested a review from a team as a code owner December 16, 2020 20:06
@notmgsk notmgsk force-pushed the client-side-calibration-expansion branch from 46658fb to fb529b6 Compare December 28, 2020 13:53
else:
return self._calibration_program

def expand_calibrations(self, program: Program, discard_defcals: bool = True) -> Program:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO this logic should be on Program, or in a standalone function, for use where a QPUCompiler doesn't make sense

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants