Names the log door the answer-parent entry stamps - #87
Merged
Conversation
`entry: :answer_parent` stopped being telemetry only when ADR-0010 landed: on an adapter that keeps an input log, `entry:` also stamps the `door` of the entry appended to the parent's log (decision 5's table, through the done/failed re-entry `respond_to_parent/3` performs). The comment above `respond_to_parent/3` still said "telemetry only", which reads as a standing claim rather than the pre-ADR-0010 one it was. `invoke_id:` and `child_count:` keep the claim - they really are telemetry only - and lose the "too" that tied them to a door that is not. Also adds a dated Note under ADR-0010 decision 2 marking its "currently have zero occurrences in `lib/`" as the authoring-time naming ground it was: `sp-80g` landed those names. Zero removed lines in `docs/adr/`. No changelog fragment: nothing here is visible to a caller of the public API. Full `mix quality` green, attested. Refs: sp-f1s
johnnyt
force-pushed
the
sp-f1s-answer-parent-log-door
branch
from
September 6, 2026 23:27
23c99c1 to
e88f6c1
Compare
Pass-1 direction review, finding 1 (RECORD-PROSE): the Note said all five of decision 2's names occur in `lib/` today. Four do - `append_input`, `list_inputs`, `input_log` and `supports_input_log?`, landed by `sp-80g`. `Recording` has zero occurrences in `lib/` and is meant to: it is upstream's, and decision 8's mapping onto it is named in the record and built nowhere. The Note now says so, so it retires decision 2's stale claim without minting a new one. Still zero removed lines under `docs/adr/`. Full `mix quality` green. Refs: sp-f1s
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bead: sp-f1s (filed by the campaign-034 conductor from sp-t12's two open
items; scheduled as an SF035 lane P fill).
What changed
Two things, both about the same stale sentence.
lib/statifier_persistence/driver.ex- the comment aboverespond_to_parent/3saidentry: :answer_parent"is telemetry only".ADR-0010 decision 5 made that false: on an adapter that keeps an input
log,
entry:also stamps thedoorof the entry appended to theparent's log, through the
done_invocation/5/failed_invocation/5re-entry that function performs (decision 5's table gives
:answer_parentan "appends: yes" row). The comment now names the logdoor.
invoke_id:andchild_count:keep the telemetry-only claim,which is still true of them, and lose the "too" that tied them to a
door that no longer carries it.
runs.ex'st:opt/0doc already saysthis correctly; only
driver.exwas left behind.docs/adr/0010-durable-per-run-input-log.md- a dated Note underdecision 2 marking its "
append_input,list_inputs,input_log,supports_input_log?andRecordingcurrently have zero occurrences inlib/" as the authoring-time ground for the naming choice rather than astanding claim.
sp-80glanded the four callback and facadenames, so the sentence reads as falsified without the Note; it was never
a decision, only the reasoning for one.
Recordingis the exception andstays upstream's - decision 8's mapping onto it is named in the record
and built nowhere - and the Note says so (cure for the pass-1 direction
review finding, commit
12289f9). Amend-by-addition in the record'sown established Note shape
(the record already carries ten dated
**Note (...)**sections,decision 1's at lines 139-150 among them). Zero removed lines in
docs/adr/.Acceptance criteria
driver.ex:794-801nownames
door, the parent's input log, and ADR-0010 decision 5.git diff origin/main -- docs/adr/ | grep -c '^-[^-]'returns0.Provenance
lib/statifier_persistence/driver.ex(the commentlines) and
docs/adr/0010-*.md(the optional Note). Nothing outside it wastouched.
driver.ex:717; onmainat19f2cedit is at:794. Reported as a brief correction, not acted ondifferently.
changelog.d/README.mdthis is invisible to acaller of the public API (a comment and a record Note).
sp-e8c(storage.exmoduledoc); the two touch disjointfiles. No rebase-over-sibling resolution was needed.
Verification
Full
mix qualitygreen on the branch head, attested viamix quality.verify(attested: true, scopeall, no profile): format,compile, credo, dialyzer, deps, 482/482 tests, 95.7% coverage. Postgres was
the local server on
localhost:5432.