-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename the library from QRCode to QRCodeGenerator #36
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These small changes made my headache go away about compilation error. It would be a great change for library!
You're welcome @AsmanovLev! :) |
meeerge and release a new version pls :). this PR works for me |
Merge and release plssssss. |
please release this.. |
gogogo |
Hi @ricmoo, please check this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
The name QRcode conflicts with the Espressif's addons for ESP boards. It is a great move to rename this project to QRCodeGenerator to avoid conflicts.