When parsing a line with no key, just skip it instead of throwing (#133)

rickyah · Feb 17, 2017 · 0d79c77 · 0d79c77
1 parent 187890c
commit 0d79c77
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 14 deletions.
diff --git a/src/IniFileParser.Tests/Unit/Configuration/ConfigurationTests.cs b/src/IniFileParser.Tests/Unit/Configuration/ConfigurationTests.cs
@@ -67,12 +67,6 @@ public LiberalTestConfiguration()
 name = Marble Zone
 ";
 
-        string iniFileReallyBad =
-@"
-{no section}
-key # = wops!
-= value
-";
         #endregion 
 
         [SetUp]
@@ -107,12 +101,6 @@ public void check_configuration_is_correct()
             Assert.That(_parser.Parse(iniFileStr).Configuration, Is.InstanceOf(typeof(LiberalTestConfiguration)));
         }
 
-        [Test]
-        public void parser_really_bad_ini_format()
-        {
-            Assert.That(_parser.Parse(iniFileReallyBad), Is.Null);    
-        }
-
         [Test]
         public void parse_not_so_good_ini_format()
         {

diff --git a/src/IniFileParser.Tests/Unit/Parser/ParserTests.cs b/src/IniFileParser.Tests/Unit/Parser/ParserTests.cs
@@ -262,7 +262,8 @@ public void allow_skiping_unparsable_lines()
         {
             string data =
                 @"win] 
-key1 = value1";
+key1 = value1
+ = value2";
 
             var parser = new IniDataParser();
 
@@ -508,5 +509,7 @@ [W103 0.5' wc]
 			Assert.That(parsedData.Sections["W101 0.5\" wc"], Is.Not.Empty);
 			Assert.That(parsedData.Sections["W103 0.5' wc"], Is.Not.Empty);
 		}
+
+
     }
 }
diff --git a/src/IniFileParser/Model/Configuration/IniParserConfiguration.cs b/src/IniFileParser/Model/Configuration/IniParserConfiguration.cs
@@ -208,7 +208,7 @@ public string NewLineStr
         ///     Defaults to <c>true</c>.
         /// </remarks>
         public bool AllowKeysWithoutSection { get; set; }
-
+			
         /// <summary>
         ///     If set to <c>false</c> and the <see cref="IniDataParser"/> finds duplicate keys in a
         ///     section the parser will stop with an error.

diff --git a/src/IniFileParser/Parser/IniDataParser.cs b/src/IniFileParser/Parser/IniDataParser.cs
@@ -344,6 +344,9 @@ protected virtual void ProcessKeyValuePair(string line, IniData currentIniData)
         {
             // get key and value data
             string key = ExtractKey(line);
+
+			if (string.IsNullOrEmpty(key) && Configuration.SkipInvalidLines) return;
+
             string value = ExtractValue(line);
 
             // Check if we haven't read any section yet