🛡️ Sentinel: [HIGH] Fix Stored XSS in dashboard tables#23
🛡️ Sentinel: [HIGH] Fix Stored XSS in dashboard tables#23
Conversation
- Refactored devices.js, users.js, and rmcs.js to use jQuery's safe DOM construction methods (.text()) instead of innerHTML concatenation. - Replaced unsafe onclick attributes with programmatic event listeners (.click()). - Ensured variable parts in popover content are safely escaped. - Cleaned up unused and insecure helper functions. Co-authored-by: richkmeli <7313162+richkmeli@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
🚨 Severity: HIGH
💡 Vulnerability: Stored Cross-Site Scripting (XSS) in Devices, Users, and RMCs dashboard tables.
🎯 Impact: An attacker (or a compromised/malicious "infected" device) could inject malicious scripts into the dashboard, which would execute in the context of the administrator's session when they view the devices or users list. This could lead to session hijacking or unauthorized actions.
🔧 Fix: Refactored `devices.js`, `users.js`, and `rmcs.js` to use jQuery's safe DOM construction methods (`.text()`) and programmatic event listeners (`.click()`) instead of `innerHTML` concatenation and `onclick` attributes.
✅ Verification: Code verified manually to ensure all user-controlled variables are now handled safely. Code review confirmed the fix is correct and follows best practices.
PR created automatically by Jules for task 13009380922472149181 started by @richkmeli