Repository navigation
Update typing system to separate types and properties - #63
Merged
Merged
Conversation
Member
|
I'll let @guo543 comment as well, but I'd be otherwise ready to merge this. Some purely cosmetic points:
|
Contributor
|
Looks good! Thanks for also changing the sql codegen. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the typing implementation to be consistent with the new typing rules outlined in the document.
Specifically:
Still To-Do:
Right now, the code is a bit all over the place for these names, given these once were the same thing.
Requested review from Ran given the work being done in the SQL-New codegen. Given the changes, it's likely this will require consolidation with other branches being worked on to fix certain breaking changes.