-
Notifications
You must be signed in to change notification settings - Fork 71
chore: Fix SetLogger warning and image ref to use multiarch images with fully qualified names. #924
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi @IshwarKanse. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test |
7933d46 to
21f5cb3
Compare
|
cc @lihongyan1 |
423780b to
6afcca3
Compare
|
@IshwarKanse mind fixing the commit message to |
6afcca3 to
92e5979
Compare
92e5979 to
7c7955f
Compare
|
@jan--f All tests passed. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: IshwarKanse, jan--f The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The PR fixes the SetLogger warning we get during test execution.
And images not being pulled with short name restrictions.