Skip to content

Conversation

@IshwarKanse
Copy link
Contributor

@IshwarKanse IshwarKanse commented Nov 6, 2025

The PR fixes the SetLogger warning we get during test execution.

    observability_installer_test.go:240: job verify-traces-traceql-grpc didn't succeed yet
[controller-runtime] log.SetLogger(...) was never called; logs will not be displayed.
Detected at:
	>  goroutine 115 [running]:
	>  runtime/debug.Stack()
	>  	/opt/homebrew/Cellar/go/1.24.6/libexec/src/runtime/debug/stack.go:26 +0x64
	>  sigs.k8s.io/controller-runtime/pkg/log.eventuallyFulfillRoot()
	>  	/Users/ikanse/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/log/log.go:60 +0xf4
	>  sigs.k8s.io/controller-runtime/pkg/log.(*delegatingLogSink).WithValues(0x14000426ec0, {0x0, 0x0, 0x0})
	>  	/Users/ikanse/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/log/deleg.go:168 +0x38
	>  github.com/go-logr/logr.Logger.WithValues(...)
	>  	/Users/ikanse/go/pkg/mod/github.com/go-logr/[email protected]/logr.go:332
	>  sigs.k8s.io/controller-runtime/pkg/log.FromContext({0x102d9ee68?, 0x1043b9940?}, {0x0?, 0x0?, 0x0?})
	>  	/Users/ikanse/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/log/log.go:98 +0xac
	>  sigs.k8s.io/controller-runtime/pkg/log.(*KubeAPIWarningLogger).HandleWarningHeaderWithContext(0x140005554e8, {0x102d9ee68?, 0x1043b9940?}, 0x12b, {0xb?, 0x102225136?}, {0x1400058c300, 0xa3})
	>  	/Users/ikanse/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/log/warning_handler.go:49 +0x54
	>  k8s.io/client-go/rest.handleWarnings({0x102d9ee68, 0x1043b9940}, 0x10?, {0x102d73680?, 0x140005554e8?})
	>  	/Users/ikanse/go/pkg/mod/k8s.io/[email protected]/rest/warnings.go:187 +0xe0
	>  k8s.io/client-go/rest.(*Request).transformResponse(0x14000c7bc80, {0x102d9ee68, 0x1043b9940}, 0x14000013e60, 0x140003cb7c0)
	>  	/Users/ikanse/go/pkg/mod/k8s.io/[email protected]/rest/request.go:1263 +0x320
	>  k8s.io/client-go/rest.(*Request).Do.func1(0x1400095e800?, 0xa?)
	>  	/Users/ikanse/go/pkg/mod/k8s.io/[email protected]/rest/request.go:1137 +0x44
	>  k8s.io/client-go/rest.(*Request).request.func3.1(...)
	>  	/Users/ikanse/go/pkg/mod/k8s.io/[email protected]/rest/request.go:1107
	>  k8s.io/client-go/rest.(*Request).request.func3(0x14000013e60, 0x14000747b78, {0x102d9f458?, 0x1400095e800?}, 0x14000013e60?, 0x0?, 0x140003cb7c0, {0x0?, 0x0?}, 0x0?)
	>  	/Users/ikanse/go/pkg/mod/k8s.io/[email protected]/rest/request.go:1114 +0xb8
	>  k8s.io/client-go/rest.(*Request).request(0x14000c7bc80, {0x102d9ee68, 0x1043b9940}, 0x14000747b78)
	>  	/Users/ikanse/go/pkg/mod/k8s.io/[email protected]/rest/request.go:1116 +0x400
	>  k8s.io/client-go/rest.(*Request).Do(0x14000c7bc80, {0x102d9ee68, 0x1043b9940})
	>  	/Users/ikanse/go/pkg/mod/k8s.io/[email protected]/rest/request.go:1136 +0xd8
	>  sigs.k8s.io/controller-runtime/pkg/client.(*unstructuredClient).Delete(0x1400049eb58?, {0x102d9ee68, 0x1043b9940}, {0x102dd0a18?, 0x1400008f6e8?}, {0x0, 0x0, 0x102e36d1a?})
	>  	/Users/ikanse/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/client/unstructured_client.go:114 +0x328
	>  sigs.k8s.io/controller-runtime/pkg/client.(*client).Delete(0x1400049eb40?, {0x102d9ee68?, 0x1043b9940?}, {0x102dd0a18?, 0x1400008f6e8?}, {0x0?, 0x0?, 0x0?})
	>  	/Users/ikanse/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/client/client.go:298 +0x124
	>  github.com/rhobs/observability-operator/test/e2e.testObservabilityInstallerTracing.func10()
	>  	/Users/ikanse/observability-operator/test/e2e/observability_installer_test.go:189 +0x4c
	>  github.com/rhobs/observability-operator/test/e2e.testObservabilityInstallerTracing.(*Framework).CleanUp.func19()
	>  	/Users/ikanse/observability-operator/test/e2e/framework/framework.go:256 +0x50
	>  testing.(*common).Cleanup.func1()
	>  	/opt/homebrew/Cellar/go/1.24.6/libexec/src/testing/testing.go:1211 +0xf4
	>  testing.(*common).runCleanup(0x140000eac40, 0x140007de6e0?)
	>  	/opt/homebrew/Cellar/go/1.24.6/libexec/src/testing/testing.go:1445 +0xe4
	>  testing.tRunner.func2()
	>  	/opt/homebrew/Cellar/go/1.24.6/libexec/src/testing/testing.go:1786 +0x2c
	>  testing.tRunner(0x140000eac40, 0x102d68290)
	>  	/opt/homebrew/Cellar/go/1.24.6/libexec/src/testing/testing.go:1798 +0x110
	>  created by testing.(*T).Run in goroutine 107
	>  	/opt/homebrew/Cellar/go/1.24.6/libexec/src/testing/testing.go:1851 +0x374

And images not being pulled with short name restrictions.

Warning Failed  47m (x41 over 3h52m)   kubelet Failed to pull image "minio/minio": short name mode is enforcing, but image name minio/minio:latest returns ambiguous list
Warning Failed     16s (x2 over 33s) kubelet      Failed to pull image "curlimages/curl:latest": short name mode is enforcing, but image name curlimages/curl:latest returns ambiguous list

@openshift-ci
Copy link

openshift-ci bot commented Nov 6, 2025

Hi @IshwarKanse. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@danielmellado
Copy link
Contributor

/ok-to-test

@IshwarKanse IshwarKanse changed the title chore: Fix SetLogger warning chore: Fix SetLogger warning and image ref to use multiarch images with fully qualified names. Nov 6, 2025
@IshwarKanse
Copy link
Contributor Author

cc @lihongyan1

@IshwarKanse IshwarKanse force-pushed the fixloggerwarn branch 3 times, most recently from 423780b to 6afcca3 Compare November 7, 2025 10:42
@jan--f
Copy link
Collaborator

jan--f commented Dec 2, 2025

@IshwarKanse mind fixing the commit message to fix: SetLogger warning and image ref

@IshwarKanse
Copy link
Contributor Author

@jan--f All tests passed.

@jan--f
Copy link
Collaborator

jan--f commented Dec 3, 2025

/lgtm
/approve

@openshift-ci
Copy link

openshift-ci bot commented Dec 3, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IshwarKanse, jan--f

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Dec 3, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit fd5645c into rhobs:main Dec 3, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants