Fstab handling moves to blivet #6160
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vojtechtrefny
temporarily deployed
to
gh-cockpituous
GitHub Actions
Inactive
vojtechtrefny
force-pushed
the
main_fstab-blivet
branch
from
fb3c0b9 to
18bb618
Compare
vojtechtrefny
temporarily deployed
to
gh-cockpituous
GitHub Actions
Inactive
vojtechtrefny
force-pushed
the
main_fstab-blivet
branch
from
18bb618 to
8481ca5
Compare
vojtechtrefny
temporarily deployed
to
gh-cockpituous
GitHub Actions
Inactive
|
/kickstart-test --testtype storage |
|
/kickstart-test --testtype smoke |
|
There are some test failures in Web UI tests here. Some are because the PR is not rebased, (I will rebase to recheck) but some (the home-reuse scenario) tests look like real failures. I will debug these and get back to you |
Anaconda handling fstab is something that should be done by blivet. This moves the fstab logic into the blivet. Crypttab and blkidtab handling is not supported by blivet yet so it remains mostly unchanged (for now)
KKoukiou
force-pushed
the
main_fstab-blivet
branch
from
8481ca5 to
2989795
Compare
KKoukiou
requested changes
Mar 7, 2025
| if device.type == "btrfs volume" and "subvol=" in options: | ||
| log.debug("subvolume from %s for %s not found", options, devspec) | ||
| continue | ||
| # If a btrfs volume is found but a subvolume is expected, ignore the volume. |
There was a problem hiding this comment.
@vojtechtrefny For some reason I think this does not work as expected. The Web UI test fail because the mount-points do not have subvolumes in the GetExistingSystems information for mount points.
My test has an fstab like this:
UUID=0d5f616b-6146-4a37-b7f7-9810fb3ed940 / btrfs compress=zstd:1,defaults,subvol=root 0 1
UUID=7a3fd253-11ba-432e-9d9a-98f07dfc5caa /boot ext4 defaults 0 0
UUID=0d5f616b-6146-4a37-b7f7-9810fb3ed940 /home btrfs compress=zstd:1,subvol=home 0 0
UUID=0d5f616b-6146-4a37-b7f7-9810fb3ed940 /var btrfs compress=zstd:1,subvol=var 0 0
UUID=D69D-DAED /boot/efi vfat defaults,umask=0077,shortname=winnt 0 0
The object for existing systems that I get from the API is:
[
{
"devices": {
"t": "as",
"v": [
"BTRFS-0d5f616b-6146-4a37-b7f7-9810fb3ed940",
"vda3",
"BTRFS-0d5f616b-6146-4a37-b7f7-9810fb3ed940",
"BTRFS-0d5f616b-6146-4a37-b7f7-9810fb3ed940",
"vda2"
]
},
"mount-points": {
"t": "a{ss}",
"v": {
"/": "BTRFS-0d5f616b-6146-4a37-b7f7-9810fb3ed940",
"/boot": "vda3",
"/home": "BTRFS-0d5f616b-6146-4a37-b7f7-9810fb3ed940",
"/var": "BTRFS-0d5f616b-6146-4a37-b7f7-9810fb3ed940",
"/boot/efi": "vda2"
}
},
"os-name": {
"t": "s",
"v": "Fedora Linux 43 for x86_64"
}
}
]
The subvolumes are not put correctly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebased and updated version of #5793 Requires some fixes and changes in blivet that are not yet released so I am marking this as blocked. Blivet 3.12 will be available in Fedora 42, but this targets Fedora 43.