This repository was archived by the owner on Oct 6, 2025. It is now read-only.
Add support for Raw Phoneme Input and Other Phonemes#742
Open
kbickar wants to merge 3 commits intorhasspy:masterfrom
Open
Add support for Raw Phoneme Input and Other Phonemes#742kbickar wants to merge 3 commits intorhasspy:masterfrom
kbickar wants to merge 3 commits intorhasspy:masterfrom
Conversation
balloob
reviewed
Mar 8, 2025
| void rawOutputProc(vector<int16_t> &sharedAudioBuffer, mutex &mutAudio, | ||
| condition_variable &cvAudio, bool &audioReady, | ||
| bool &audioFinished); | ||
| void parseArgs(int argc, char* argv[], RunConfig& runConfig); |
There was a problem hiding this comment.
Style changes for unrelated code should not be in this PR. If a formatter should be used, we should put that in a different PR.
Author
There was a problem hiding this comment.
Fair enough, I've created another containing just the formatting changes: #744
balloob
suggested changes
Mar 8, 2025
balloob
left a comment
balloob
left a comment
There was a problem hiding this comment.
Please split the style changes out of this PR.
Member
|
Development has moved: https://github.com/OHF-Voice/piper1-gpl |
ayutaz
referenced
this pull request
in ayutaz/piper-plus
Jul 19, 2025
- Added current implementation status of piper-plus - Noted that Japanese phoneme issues (#787) are already resolved - Listed existing PRs (#96-#100) for TTS improvements - Updated priorities based on what's already implemented - Focused recommendations on features not yet in piper-plus: * Raw Phoneme Input (PR #742) * IPA phonemes support (PR #401) * GPU device designation (PR #429) * Silence randomness control (Issue #817) 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes update Piper to add a new phoneme type "phonemes" that a model can be configured with signifying it accepts raw phonemes as input and a phonemizer should not be used.
The phonemes can now also be defined as multi-character (1-3) ASCII which adds support for other phonetic alphabets such as Sampa and Arpabet,
The changes from #403 have been added to allow the --phoneme-input flag to be used in addition to the model config.
Some of the code from the piper_phonemize library relating to converting phonemes to IDs has been moved back into the piper application.
The rational for these changes is it means Piper can be used with a custom phonemizer working to preprocess sentences and without the dependency on the espeak library. On the python side, the espeak library is not needed to be even installed, on the C++ side it is still linked as it's a little complicated to disentangle it.
This relates to the piper phonemizer issue: rhasspy/piper-phonemize#17