Merge pull request #83 from actionshrimp/string-split-fix

String split fix for ocaml < 4.04
rgrinberg · Oct 12, 2018 · 3309c44 · 3309c44
2 parents dbc92e8 + 79cb44e
commit 3309c44
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 2 deletions.
diff --git a/opium.opam b/opium.opam
@@ -25,6 +25,7 @@ depends: [
   "ppx_sexp_conv" {>= "v0.9.0"}
   "re" {>= "1.3.0"}
   "magic-mime"
+  "stringext"
   "alcotest" {test}
   "cow" {test & >= "0.10.0"}
 ]

diff --git a/opium/jbuild b/opium/jbuild
@@ -11,4 +11,5 @@
     cmdliner
     cohttp-lwt-unix
     magic-mime
-    logs))))
+    logs
+    stringext))))
diff --git a/opium/static_serve.ml b/opium/static_serve.ml
@@ -35,7 +35,7 @@ let public_serve t ~requested ~request_if_none_match ?etag_of_fname ?headers ()
       match request_if_none_match, etag_quoted with
       | Some request_etags, Some etag_quoted ->
         request_etags
-        |> String.split_on_char ','
+        |> Stringext.split ~on:','
         |> List.exists ~f:(fun request_etag ->
           String.trim request_etag = etag_quoted
         )