Samples/syscount: add syscount application by hzy-hits · Pull Request #29 · rex-rs/rex

hzy-hits · 2025-04-24T04:02:11Z

Three commits:

rex-macros/tracepoint.rs modifications

add hooks events

rex/src/tracepoint/bindings.rs modification

add RawSyscallEnterCtx and RawSyscallExitCtx

Syscount implemtations

Introduced loader.c for argument parsing using static methods.
Removed typedef declarations for enum types throughout the codebase to align with the Linux Kernel coding style.
Added the core rex application logic for syscount

chinrw · 2025-04-24T07:34:43Z

samples/syscount/.clang-format

Hi, could you remove this .clang-format file. We prefer not to inlucde this file in sample.

And could you use .clang-format from linux kernel

Like

clang-format -i --style=file:../../linux/.clang-format loader.c

Sure, I will remove .clang-format

samples/syscount/loader.c

jinghao-jia · 2025-04-24T07:54:23Z

samples/syscount/loader.c

+    SHOW_BOTH
+} stats_type_t;
+
+void print_header(bool timestamp, stats_type_t type) {


This function should be static

jinghao-jia · 2025-04-24T07:54:40Z

samples/syscount/loader.c

+    exiting = true;
+}
+
+typedef enum {


typedef is still here

jinghao-jia · 2025-04-24T07:57:37Z

samples/syscount/loader.c

+    char *filter_syscalls;
+};
+
+void print_usage(const char *prog_name) {


This function should also be static

chinrw · 2025-04-24T10:09:35Z

Hi, could you help rewrite the commit message to follow our current style and signoff the commits.

jinghao-jia · 2025-04-25T01:11:36Z

The last commit (Merge branch 'main' into main) seems unnecessary, can you drop it?

jinghao-jia · 2025-04-25T01:37:05Z

samples/syscount/loader.c

Looks like this file is still not formatted?

jinghao-jia

LGTM, thanks for the hard work!

jinghao-jia · 2025-04-25T02:41:10Z

@hzy-hits it looks like the DCO check failure is because the author name and the sign-off name are different (both the first and the third commit have this problem):

Author: Ivena <huangzhy77@outlook.com>
Date:   Thu Apr 24 20:41:47 2025 -0400

    samples/syscount: add syscount tool

    Signed-off-by: Zhenyu Huang <huangzhy77@outlook.com>

Are you directly using the Signed-off-by tag generated by git?

Signed-off-by: Ivena <huangzhy77@outlook.com>

hzy-hits · 2025-04-25T02:53:24Z

@hzy-hits it looks like the DCO check failure is because the author name and the sign-off name are different (both the first and the third commit have this problem):
Author: Ivena <huangzhy77@outlook.com>
Date:   Thu Apr 24 20:41:47 2025 -0400

    samples/syscount: add syscount tool

    Signed-off-by: Zhenyu Huang <huangzhy77@outlook.com>
Are you directly using the Signed-off-by tag generated by git?

I rebased the commits and signed with author's name. Now all commits' sign-off are generated directly. Hope this time it would pass the workflow check.

Thanks for your patience and guidance. I learn quite a lot from this PR

jinghao-jia · 2025-04-25T02:57:15Z

@hzy-hits it looks like the DCO check failure is because the author name and the sign-off name are different (both the first and the third commit have this problem):
Author: Ivena <huangzhy77@outlook.com>
Date:   Thu Apr 24 20:41:47 2025 -0400

    samples/syscount: add syscount tool

    Signed-off-by: Zhenyu Huang <huangzhy77@outlook.com>
Are you directly using the Signed-off-by tag generated by git?
I rebased the commits and signed with author's name. Now all commits' sign-off are generated directly. Hope this time it would pass the workflow check.

Thanks for your patience and guidance. I learn quiet a lot from this PR

No problem! Sorry that we requested so many changes ;)

hzy-hits marked this pull request as ready for review April 24, 2025 04:02

chinrw reviewed Apr 24, 2025

View reviewed changes

jinghao-jia reviewed Apr 24, 2025

View reviewed changes

samples/syscount/loader.c Show resolved Hide resolved

jinghao-jia reviewed Apr 24, 2025

View reviewed changes

samples/syscount/loader.c Outdated

exiting = true;

}

typedef enum {

Copy link

Member

jinghao-jia Apr 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typedef is still here

jinghao-jia reviewed Apr 24, 2025

View reviewed changes

hzy-hits closed this Apr 24, 2025

hzy-hits force-pushed the main branch from 1740773 to 7156aec Compare April 24, 2025 23:41

hzy-hits reopened this Apr 25, 2025

hzy-hits force-pushed the main branch 3 times, most recently from ddbd227 to 289de72 Compare April 25, 2025 01:17

jinghao-jia reviewed Apr 25, 2025

View reviewed changes

hzy-hits force-pushed the main branch from 289de72 to 214f866 Compare April 25, 2025 02:21

jinghao-jia approved these changes Apr 25, 2025

View reviewed changes

hzy-hits force-pushed the main branch from 214f866 to 39b7b78 Compare April 25, 2025 02:47

hzy-hits added 3 commits April 24, 2025 22:49

rex-macros/tracepoint: add RawSyscallEnter/Exit Ctx events

51030a9

Signed-off-by: Ivena <huangzhy77@outlook.com>

rex/tracepoint: add RawSyscallEnter/ExitCtx struct

fee3e57

Signed-off-by: Ivena <huangzhy77@outlook.com>

samples/syscount: add syscount tool

95fa700

Signed-off-by: Ivena <huangzhy77@outlook.com>

hzy-hits force-pushed the main branch from 39b7b78 to 95fa700 Compare April 25, 2025 02:49

jinghao-jia enabled auto-merge April 25, 2025 02:58

chinrw approved these changes Apr 25, 2025

View reviewed changes

jinghao-jia merged commit 97870df into rex-rs:main Apr 25, 2025
4 checks passed

Conversation

hzy-hits commented Apr 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

chinrw commented Apr 24, 2025

Uh oh!

jinghao-jia commented Apr 25, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jinghao-jia left a comment

Choose a reason for hiding this comment

Uh oh!

jinghao-jia commented Apr 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hzy-hits commented Apr 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jinghao-jia commented Apr 25, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

hzy-hits commented Apr 24, 2025 •

edited

Loading

jinghao-jia commented Apr 25, 2025 •

edited

Loading

hzy-hits commented Apr 25, 2025 •

edited

Loading