Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 279 remove unnecessary unwraps #292

Merged
merged 3 commits into from
Apr 7, 2024

Conversation

naomijub
Copy link
Collaborator

@naomijub naomijub commented Apr 7, 2024

Partially Addresses #279

@naomijub naomijub changed the base branch from main to v0.6 April 7, 2024 02:53
Copy link

codecov bot commented Apr 7, 2024

Codecov Report

Attention: Patch coverage is 19.71831% with 114 lines in your changes are missing coverage. Please review.

Project coverage is 37.70%. Comparing base (b31471b) to head (462e7b8).

Files Patch % Lines
crates/prefab/src/save.rs 37.50% 20 Missing ⚠️
crates/editor_ui/src/camera_view.rs 0.00% 16 Missing ⚠️
crates/editor_core/src/load.rs 0.00% 14 Missing ⚠️
crates/editor_core/src/gltf_unpack.rs 0.00% 13 Missing ⚠️
crates/editor_tabs/src/lib.rs 0.00% 10 Missing ⚠️
crates/editor_ui/src/inspector/mod.rs 0.00% 7 Missing ⚠️
crates/prefab/src/sub_scene/mod.rs 12.50% 7 Missing ⚠️
crates/editor_tabs/src/start_layout.rs 0.00% 6 Missing ⚠️
crates/editor_ui/src/settings.rs 0.00% 6 Missing ⚠️
crates/prefab/src/editor_registry/mod.rs 60.00% 6 Missing ⚠️
... and 3 more
Additional details and impacted files
@@            Coverage Diff             @@
##             v0.6     #292      +/-   ##
==========================================
- Coverage   37.98%   37.70%   -0.28%     
==========================================
  Files          69       69              
  Lines        9743     9812      +69     
==========================================
- Hits         3701     3700       -1     
- Misses       6042     6112      +70     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@naomijub naomijub marked this pull request as ready for review April 7, 2024 04:56
@naomijub naomijub merged commit 7d78b9b into v0.6 Apr 7, 2024
10 of 12 checks passed
@naomijub naomijub deleted the issue-279-remove-unnecessary-unwraps branch April 7, 2024 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant