update

rewin123 · Apr 5, 2024 · 4b2814c · 4b2814c
1 parent 5c5f514
commit 4b2814c
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/.github/workflows/example_validation.yml b/.github/workflows/example_validation.yml
@@ -122,7 +122,7 @@ jobs:
           target: x86_64-unknown-linux-gnu
       - name: Build bevy
         # this uses the same command as when running the example to ensure build is reused
-        run: TRACE_CHROME=trace-spawn_prefab_with_physics.json CI_TESTING_CONFIG=.github/example-run/spawn_prefab_with_physics.ron cargo +nightly build --example spawn_prefab_with_physics --release --features "bevy_xpbd_3d,bevy/bevy_ci_testing,bevy/trace_chrome,bevy/trace"
+        run: CARGO_PROFILE_RELEASE_DEBUG=true TRACE_CHROME=trace-spawn_prefab_with_physics.json CI_TESTING_CONFIG=.github/example-run/spawn_prefab_with_physics.ron cargo +nightly build --example spawn_prefab_with_physics --release --features "bevy_xpbd_3d,bevy/bevy_ci_testing,bevy/trace_chrome,bevy/trace"
         env:
           CARGO_INCREMENTAL: 0
           RUSTFLAGS: "-C debuginfo=0 -Z location-detail=none -Z threads=24"
@@ -134,7 +134,7 @@ jobs:
           example_name=`basename plaformer.ron`
           echo -n $example_name > last_example_run
           echo "running spawn_prefab_with_physics - "`date`
-          time TRACE_CHROME=trace-spawn_prefab_with_physics.json CI_TESTING_CONFIG=.github/example-run/spawn_prefab_with_physics.ron xvfb-run cargo +nightly run --release --example spawn_prefab_with_physics --features "bevy_xpbd_3d,bevy/bevy_ci_testing,bevy/trace_chrome,bevy/trace"
+          time CARGO_PROFILE_RELEASE_DEBUG=true TRACE_CHROME=trace-spawn_prefab_with_physics.json CI_TESTING_CONFIG=.github/example-run/spawn_prefab_with_physics.ron xvfb-run cargo +nightly run --release --example spawn_prefab_with_physics --features "bevy_xpbd_3d,bevy/bevy_ci_testing,bevy/trace_chrome,bevy/trace"
           sleep 10
           if [ `find ./ -maxdepth 1 -name 'screenshot-*.png' -print -quit` ]; then
             mkdir screenshots-spawn_prefab_with_physics

diff --git a/src/main.rs b/src/main.rs
@@ -4,11 +4,12 @@ use space_editor::SpaceEditorPlugin;
 use space_editor_ui::{game_mode_changed, settings::GameModeSettings, simple_editor_setup};
 
 fn main() {
-    #[cfg(feature = "backtrace")]
+    /// Backtrace only supported on unix
+    #[cfg(all(feature = "backtrace" , not(target_os = "windows")))]
     unsafe {
         backtrace_on_stack_overflow::enable()
     };
-
+    
     let mut app = App::new();
     app.add_plugins(DefaultPlugins.set(WindowPlugin {
         primary_window: Some(Window {