cargo clippy

examples/platformer.rs

@@ -8,7 +8,6 @@ use bevy::{
 };
 use bevy_xpbd_3d::{
     prelude::{AngularVelocity, LinearVelocity, Position, RayHits},
-    PhysicsSchedule, PhysicsStepSet,
 };
 use space_editor::prelude::{component::EntityLink, spatial_query::RayCasterPrefab, *};
 
@@ -100,7 +99,7 @@ fn move_player(
 ) {
     for (_e, mut vel, mut rot, mut controller, hits, tranform) in query.iter_mut() {
         //take 1th hit, because 0th hit is self hit
-        if let Some(hit) = hits.iter_sorted().nth(0) {
+        if let Some(hit) = hits.iter_sorted().next() {
             if hit.time_of_impact > 0.7 {
                 continue;
             }

src/editor/core/gltf_unpack.rs

@@ -48,7 +48,7 @@ fn unpack_gltf_event(
     assets: Res<AssetServer>,
     mut queue: ResMut<GltfSceneQueue>,
 ) {
-    for event in events.iter() {
+    for event in events.read() {
         queue.0.push(assets.load(event.path.clone()));
     }
     events.clear();
@@ -76,7 +76,7 @@ fn unpack_gltf(world: &mut World) {
     let loaded_scenes = {
         let mut events = world.resource_mut::<Events<GltfLoaded>>();
         let mut reader = events.get_reader();
-        let loaded = reader.iter(&events).cloned().collect::<Vec<GltfLoaded>>();
+        let loaded = reader.read(&events).cloned().collect::<Vec<GltfLoaded>>();
         events.clear();
         loaded
     };

src/editor/core/mod.rs

@@ -70,7 +70,7 @@ fn editor_event_listener(
     cache: ResMut<PrefabMemoryCache>,
     mut gltf_events: EventWriter<gltf_unpack::EditorUnpackGltf>,
 ) {
-    for event in events.iter() {
+    for event in events.read() {
         match event {
             EditorEvent::Load(path) => match path {
                 EditorPrefabPath::File(path) => {

src/editor/mod.rs

@@ -10,7 +10,7 @@ pub mod ui_registration;
 use bevy_egui::{EguiContext, EguiContexts};
 use bevy_inspector_egui::{quick::WorldInspectorPlugin, DefaultInspectorConfigPlugin};
 use bevy_mod_picking::{
-    backends::raycast::{bevy_mod_raycast::prelude::RaycastSettings, RaycastPickable},
+    backends::raycast::{RaycastPickable},
     prelude::*,
     PickableBundle,
 };
@@ -140,7 +140,7 @@ struct SelectEvent {
     event: ListenerInput<Pointer<Down>>,
 }
 
-fn create_grid_lines(mut commands: Commands) {
+fn create_grid_lines(commands: Commands) {
     bevy_debug_grid::spawn_floor_grid(commands);
 }
 

src/editor/ui/bot_menu.rs

@@ -184,7 +184,7 @@ pub fn bot_menu(
         });
     });
 
-    for event in events.iter() {
+    for event in events.read() {
         menu_state.path = event.path.clone();
         editor_events.send(EditorEvent::Load(EditorPrefabPath::File(format!(
             "{}.scn.ron",

src/editor/ui/inspector/mod.rs

@@ -265,7 +265,7 @@ pub fn inspect(ui: &mut egui::Ui, world: &mut World) {
                     let _counter = 0;
                     for idx in 0..components_id.len() {
                         let c_id = components_id[idx];
-                        let t_id = types_id[idx];
+                        let _t_id = types_id[idx];
                         let name = pretty_type_name::pretty_type_name_str(
                             cell.components().get_info(c_id).unwrap().name(),
                         );

src/editor/ui/mod.rs

@@ -62,7 +62,7 @@ impl Plugin for EditorUiPlugin {
 
         app.add_plugins(bot_menu::BotMenuPlugin);
 
-        app.configure_set(
+        app.configure_sets(
             Update,
             UiSystemSet
                 .in_set(EditorSet::Editor)

src/editor_registry/mod.rs

@@ -3,7 +3,7 @@ use std::sync::Arc;
 use bevy::{
     ecs::system::{EntityCommand, EntityCommands},
     prelude::*,
-    reflect::{GetTypeRegistration, TypePath, TypeRegistry, TypeRegistryArc},
+    reflect::{GetTypeRegistration, TypePath, TypeRegistryArc},
     utils::{HashMap, HashSet},
 };
 

src/lib.rs

@@ -26,7 +26,7 @@ use prefab::PrefabPlugin;
 /// Public usage of packages that used in this crate
 pub mod ext {
     pub use bevy::prelude::*;
-    pub use bevy_debug_grid::*;
+    pub use bevy_debug_grid;
     pub use bevy_egui::*;
     pub use bevy_inspector_egui::prelude::*;
     pub use bevy_mod_picking::prelude::*;

src/prefab/component/mod.rs

@@ -54,7 +54,7 @@ pub struct AutoStruct<T: Reflect + FromReflect + Default + Clone> {
 }
 
 impl<T: Reflect + FromReflect + Default + Clone> AutoStruct<T> {
-    pub fn new(data: &T, assets: &AssetServer) -> AutoStruct<T> {
+    pub fn new(data: &T, _assets: &AssetServer) -> AutoStruct<T> {
         let mut paths = HashMap::new();
 
         if let ReflectRef::Struct(s) = data.reflect_ref() {

src/prefab/mod.rs

@@ -58,8 +58,8 @@ impl Plugin for BasePrefabPlugin {
             app.add_plugins(EditorRegistryPlugin);
         }
 
-        app.configure_set(Update, EditorSet::Game.run_if(in_state(EditorState::Game)));
-        app.configure_set(
+        app.configure_sets(Update, EditorSet::Game.run_if(in_state(EditorState::Game)));
+        app.configure_sets(
             Update,
             EditorSet::Editor.run_if(in_state(EditorState::Editor)),
         );
@@ -280,7 +280,7 @@ fn sync_asset_material(
             .insert(assets.load::<StandardMaterial>(&material.path));
     }
 
-    for e in deleted.iter() {
+    for e in deleted.read() {
         if let Some(mut cmd) = commands.get_entity(e) {
             cmd.remove::<Handle<StandardMaterial>>();
         }

src/prefab/spawn_system.rs

@@ -88,7 +88,7 @@ pub fn editor_remove_mesh(
     mut commands: Commands,
     mut query: RemovedComponents<MeshPrimitivePrefab>,
 ) {
-    for e in query.iter() {
+    for e in query.read() {
         if let Some(mut cmd) = commands.get_entity(e) {
             cmd.remove::<Handle<Mesh>>();
             info!("Removed mesh handle for {:?}", e);