Skip to content

Update libtcg to QEMU v8.2.1 #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 71 commits into
base: feature/rebase
Choose a base branch
from
Draft

Update libtcg to QEMU v8.2.1 #5

wants to merge 71 commits into from

Conversation

AntonJohansson
Copy link

No description provided.

Anton Johansson added 30 commits July 18, 2024 18:01
Added libtcg headers and sources files
543199a 
These currently have a single `translate` function which sets up QEMU to
call `gen_intermediate_code`.

Signed-off-by: Anton Johansson <[email protected]>
scripts: Add libtcg enable/disable meson-buildoptions
e63347b 
Signed-off-by: Anton Johansson <[email protected]>
Add libtcg options to configure script
4532176 
Signed-off-by: Anton Johansson <[email protected]>
Override cpu_ld*_code functions
a0e3ee6 
We now instead read bytecode from a buffer with a specified virtual
address.

Signed-off-by: Anton Johansson <[email protected]>
accel/tcg: remove plugins and QEMUs tcg prologue/epilogue
1da5062 
Excludes prologues/epilogues inserted during translation.

Signed-off-by: Anton Johansson <[email protected]>
accel/tcg: don't early exit code reads
3a698e3 
Don't rely on cached address translations, we always want to fetch
memory directly from the user provided buffer, even if we've translated
this virtual address previously.
libtcg: exposed an adapted version of QEMUs tcg api
10a694d 
This is a big commit as a lot of code has been pasted and adapted from
the `tcg/*` files.

A new function to dump a `TinyCodeInstruction` was added that is adapted
from `tcg_dump_ops`. Everything exposed in `libtcg.h` was requried for
our new dump function to replicate the output of `tcg_dump_ops`.

Signed-off-by: Anton Johansson <[email protected]>
libtcg: pass code buffer via CPU state instead of globals
92b4ad7 
Signed-off-by: Anton Johansson <[email protected]>
libtcg: Split args in 3, formatting names out of band
e2a9753 
Expose arguments as 3 separate arrays (input-, output-, and constant
args.). Similar to the normal TCG API, but easiers to work with.

Signed-off-by: Anton Johansson <[email protected]>
libtcg: better naming, moved initialization from translate
6b5dbd6 
Also added destroy function for LibTcgInstructionList.

Signed-off-by: Anton Johansson <[email protected]>
libtcg: added comment/removed TODO
4b04877 
Signed-off-by: Anton Johansson <[email protected]>
libtcg: fix typos
428c02b 
Signed-off-by: Anton Johansson <[email protected]>
libtcg: added TODO to tinycode_temp_create_name
bb49f65 
Signed-off-by: Anton Johansson <[email protected]>
libtcg: removed old comment + better TODO
2c47698 
Signed-off-by: Anton Johansson <[email protected]>
libtcg: fixed handling of first 2 constant arguments
e5c50ae 
Signed-off-by: Anton Johansson <[email protected]>
libtcg: added elf.h include required by m68k
766e7ac 
Signed-off-by: Anton Johansson <[email protected]>
libtcg: fix endianness define post rebase
359d0e3 
Signed-off-by: Anton Johansson <[email protected]>
tcg: Expose tcg_get_arg_str
0b178c2 
Needed for converting arguments to a string representation for printing.

Signed-off-by: Anton Johansson <[email protected]>
libtcg: all temp variables are now stored separately
c067a4a 
This is not optimal since in terms of memory usage, as repeat use of the
same temporary will end up being stored twice, but it is easier to work
with.

TODO: Why not mimic TCG more closely and have a global temp. array for
the entire TB?

Signed-off-by: Anton Johansson <[email protected]>
libtcg: fixed bug in dump function
1a640a8 
Commas weren't printed correctly for constants

Signed-off-by: Anton Johansson <[email protected]>
[TMP] linux-user: fix aarch64
5ca3d94 
TODO: Is this still needed?

Signed-off-by: Anton Johansson <[email protected]>
Emit libtcg-helpers-$ARCH.bc
30ef543 
Adds another build artifact containing all relevant helper functions for a
given target in a LLVM bitcode .bc file.

Signed-off-by: Anton Johansson <[email protected]>

Remove QEMU subprojects when `have_libtcg` is set

This commits removes a few subprojects from QEMU when libtcg is
enabled, with reason to declutter the install directory from
non-libtcg-related stuff.

Signed-off-by: Anton Johansson <[email protected]>

llvm-helpers: Add more target-specific files

Signed-off-by: Anton Johansson <[email protected]>
libtcg: add size_in_bytes field to LibTcgInstructionList
4353e18 
size_in_bytes corresponds to the amount of bytes of input code that were
lifted to produce the translation block.

Signed-off-by: Anton Johansson <[email protected]>
libtcg: add cast to silence warnings
e1d3f72 
Signed-off-by: Anton Johansson <[email protected]>
libtcg: add LibTcgInterface struct containing func. ptrs
3d8e174 
Useful when `dlopen`ing by reducing the amount of funnctions needed to
be `dlsym`d manually. Also makes sure function prototypes are kept in
sync between users of libtcg and libtcg.

Signed-off-by: Anton Johansson <[email protected]>
libtcg: add more interface expected by revng
b9228a3 
Exposes a way to the the CPUArchState pointer along with offsets of the
stack and program counter registers.

Signed-off-by: Anton Johansson <[email protected]>
[TMP] linux-user: glibc 2.13 compatability patch
d0a1892 
Required to compile w. glibc 2.13. Remove when fixed.

Signed-off-by: Anton Johansson <[email protected]>
libtcg: expose libtcg_dump_instruction_to_buffer
1739b7e 
Adds a function for dumping a given LibTcgInstruction to a string
representation. Useful for debugging.

Signed-off-by: Anton Johansson <[email protected]>
libtcg: set TB flags
6354827 
The following flags are enabled/disabled with the goal of removing TB
overhead.

  CF_NO_GOTO_TB
  CF_NO_GOTO_PTR

    Disables all forms of translation block chaining and makes sure we
    end each TB with an exit_tb.

  ~CF_USE_ICOUNT

    Removes unnecessary overhead due to instruction count tracking.

  CF_NOIRQ

    Make TBs uninterrubtable, otherwise an extra conditional branch is
    inserted to possible skip a TB in the case of an interrupt.

Signed-off-by: Anton Johansson <[email protected]>
libtc: check result of mem_alloc
e1ec6d9 
Signed-off-by: Anton Johansson <[email protected]>
Anton Johansson added 25 commits July 18, 2024 21:06
[for-revng] linux-user: abort on forking
d2a0006 
revng will inline and analyze cpu_loop and handling of syscalls therein.
Forking in particular trips up CSAA, add an abort forcing dead code
elimination to avoid this.

Signed-off-by: Anton Johansson <[email protected]>
[TMP] [for-revng] target/hexagon: replace cpu_loop_exit_restore
e6e2796 
Replaces cpu_loop_exit_restore with cpu_loop_exit, as only the latter
was handled by the CpuLoopExit analysis. This is no longer the case, and
revng properly handles cpu_loop_exit_restore, so this commit should be
safe to delete.

Signed-off-by: Anton Johansson <[email protected]>
libtcg: refactor memory access functions
36e53dc 
Signed-off-by: Anton Johansson <[email protected]>
tcg: disable vector and i128 support for backends
c8c55d2 
Signed-off-by: Anton Johansson <[email protected]>
libtcg: assert room in buffer
b9a46c8 
Signed-off-by: Anton Johansson <[email protected]>
libtcg: remove startaddress arg. from translate
e8bd139 
Signed-off-by: Anton Johansson <[email protected]>
[TMP] hexagon: idef parser fix mem leak
3eb519d 
Signed-off-by: Anton Johansson <[email protected]>
[TMP] target/s390x: don't translate past end of buffer
94cfa3e 
Makes sure s390x will correctly exit and not read past the user provided
buffer.

TODO: This should no longer be necessary, our chech in
accel/tcg/translator.c should correctly cover s390x.

Signed-off-by: Anton Johansson <[email protected]>
libtcg: minor formatting fix
718d6a4 
Signed-off-by: Anton Johansson <[email protected]>
[post-rebase-fix] libtcg: handle negsetcond
6a4e23c 
Signed-off-by: Anton Johansson <[email protected]>
[for-revng]: comment out non-csaa-able stuff
70395f3 
Signed-off-by: Anton Johansson <[email protected]>
libtcg: expose bp register
9ecd926 
Needed for static analyses on x86 in particular.

Signed-off-by: Anton Johansson <[email protected]>
libtcg: update names
8225bf7 
Signed-off-by: Anton Johansson <[email protected]>
libtcg: introduce get_arch_info
913f8cd 
Expose arch. info such as offsets to common registers through a separate
struct instead of through LibTcgInterface. Otherwise this information is
inaccessible to the non-LibTcgInterface API.

Signed-off-by: Anton Johansson <[email protected]>
libtcg: rename
f7bee35 
Signed-off-by: Anton Johansson <[email protected]>
libtcg: allow for specifying alloc/free funcs. separately
e0cfa7b 
Only default to using malloc/free if both mem_alloc/mem_free are NULL,
needed to support arena allocators and similar where all freeing happens
at once.

Signed-off-by: Anton Johansson <[email protected]>
libtcg: add optimization and helper-to-tcg translation flags
67a4662 
Allows lifted TBs to be lightly optimized, if specified. Also adds a
flag to enable usage of automatically generated TCG variants of helper
functions (requires libtcg to be rebased on helper-to-tcg).

Signed-off-by: Anton Johansson <[email protected]>
libtcg: fix translation loop
fefdfa3 
Correctly retry translation with smaller max instruction size if
translation failed. Use TCG_MAX_INSNS instead of guessing the maximum
size, this triggered asserts in QEMU if size > TCG_MAX_INSNS.

Signed-off-by: Anton Johansson <[email protected]>
libtcg: more string dumping functions
59ea55b 
Signed-off-by: Anton Johansson <[email protected]>
libtcg: split instruction printing function
dfeaf46 
Signed-off-by: Anton Johansson <[email protected]>
tcg: don't constant propagate through registers
d29a8db 
This is to avoid retranslating blocks if the previous constant propagtion
no longer is valid. Consider a simple loop with an induction variable
initialized to 0. Upon first translation the 0 will be propagated to
uses of the induction variable. However on subsequent branches to this
block it would be retranslated and reoptimized, as the induction variable
is no longer constant.

This is not ideal for static analyses, so disable constant propagation
through registers, we still retain simpler constant propagation through
temporaries.

Signed-off-by: Anton Johansson <[email protected]>
target/cris: siglongjmp on translation bug
0b35194 
Allows static analysis tools to smoothly recover on lifting failures.

Signed-off-by: Anton Johansson <[email protected]>
target/hexagon: siglongjmp on lifting failure
e883c50 
Allows static analysis tools to smoothly skip e.g. data words which will
fail to lift.

Signed-off-by: Anton Johansson <[email protected]>
target/hexagon: disable instruction and packet counting
80669b0 
Adds unnecessary instructions not relevant for static analysis.

Signed-off-by: Anton Johansson <[email protected]>
libtcg: introduce libtcg-loader
c730fb2 
Separate shared library which acts as a simple wrapper around libtcg
compiled for different ISAs. Also handles simoultaneous use of different
libtcgs.

Signed-off-by: Anton Johansson <[email protected]>
@github-actions GitHub Actions
Copy link

Thank you for your interest in the QEMU project.

This repository is a read-only mirror of the project's repostories hosted
on https://gitlab.com/qemu-project/qemu.git.
The project does not process merge requests filed on GitHub.

QEMU welcomes contributions of code (either fixing bugs or adding new
functionality). However, we get a lot of patches, and so we have some
guidelines about contributing on the project website:
https://www.qemu.org/contribute/

@github-actions github-actions bot closed this Jul 18, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jul 18, 2024
@aleclearmind aleclearmind reopened this Jul 18, 2024
@aleclearmind aleclearmind marked this pull request as draft October 1, 2024 08:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AntonJohansson @aleclearmind