Skip to content
This repository was archived by the owner on Jan 19, 2025. It is now read-only.

fix: fix bad conflict solve#8

Open
Cristiandis wants to merge 8 commits intorevenge-mod:mainfrom
Cristiandis:main
Open

fix: fix bad conflict solve#8
Cristiandis wants to merge 8 commits intorevenge-mod:mainfrom
Cristiandis:main

Conversation

@Cristiandis
Copy link
Copy Markdown

@Cristiandis Cristiandis commented Nov 15, 2024

Fixes build issues, this time i tested it, my bad

@oSumAtrIX
Copy link
Copy Markdown
Member

What exactly is the build issue?

@Cristiandis
Copy link
Copy Markdown
Author

What exactly is the build issue?

https://github.com/revenge-mod/revenge-tweak/actions/runs/11863132717

@oSumAtrIX
Copy link
Copy Markdown
Member

oSumAtrIX commented Nov 16, 2024

Why did this occur https://github.com/revenge-mod/revenge-tweak/actions/runs/11863132717/job/33063956412#step:8:18
and how does the PR fix it? I am seeing big code blocks being removed but no explanation on why

@Cristiandis
Copy link
Copy Markdown
Author

Cristiandis commented Nov 16, 2024

Why did this occur https://github.com/revenge-mod/revenge-tweak/actions/runs/11863132717/job/33063956412#step:8:18

and how does the PR fix it? I am seeing big code blocks being removed but no explanation on why

i didn't fix conflicts correctly in the last pr so i had both the old and new version
i fixed here by looking and upstream and deleting the old part

@Cristiandis
Copy link
Copy Markdown
Author

this is the last upstream rebase i can do due to the licensing changes

@oSumAtrIX
Copy link
Copy Markdown
Member

oSumAtrIX commented Nov 20, 2024

This PR should only make the changes that are necessary to fix the build issue. Other changes will be made with a separate PR

@Cristiandis
Copy link
Copy Markdown
Author

This PR should only make the changes that are necessary to fix the build issue. Other changes will be made with a separate PR

ok, will do

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants