Fix relative time text (e.g "today ago")#53
Merged
Conversation
The previous logic bucketed by elapsed hours (<24h/<48h), so a timestamp
less than a day away but on a different calendar date could be mislabeled
(e.g. a row reading "2026-06-24 today"). Since dateRow prints the civil
date via t.Format("2006-01-02"), compare civil dates instead via a
zone-independent day index so the label always matches the visible date,
including timestamps with explicit offsets. Add a testable relativeTimeFrom
seam so the labels can be asserted deterministically.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
retlehs
approved these changes
Jun 23, 2026
retlehs
left a comment
retlehs
left a comment
Owner
There was a problem hiding this comment.
Thank you! I pushed a small follow-up that bases the today/yesterday/tomorrow labels on the calendar date
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've encountered just registered domain and it looks like
relativeTimedoesn't handle today / tomorrow duration properly:"today ago"
I've added two additional check for today and tomorrow and
func plural(n int, unit string) stringfunction.P.S the
%ssmeans literally unit string + 's'. Maybe it's a bit confusing, its not special format specifier :)