refactor: remove legacy v1 schema migration logic #4862#4925
Open
neerajvipparla wants to merge 1 commit into
Open
refactor: remove legacy v1 schema migration logic #4862#4925neerajvipparla wants to merge 1 commit into
neerajvipparla wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes for #4862 — Remove schema V1 support and metadata v2 migration
What: PR #4861 added a one-shot migration that, on node startup, detected whether the schema in the metadata store was still in the old V1 format and re-wrote it as V2. That migration code was explicitly marked // todo(azmy): Remove in Restate v1.8. This PR does that cleanup, and also removes the V1 schema deserialization path that the migration depended on.
Deleted
Modified
crates/core/src/lib.rs / crates/core/src/metadata.rs
Removed the mod metadata_migrations declaration and its pub use migrate_metadata re-export from both the inner and outer module.
crates/node/src/lib.rs
Removed the migrate_metadata import and the call to it inside Node::start. The startup sequence no longer performs a schema migration.
crates/types/src/schema/metadata/mod.rs
Removed the three additions that PR #4861 made to Schema:
crates/types/src/schema/metadata/serde_hacks.rs (largest change — ~1460 → 85 lines)
Removed all V1 schema support that predated PR #4861:
The From for super::Schema impl now expects deployments_v2 to be present — any attempt to load V1 data against v1.8+ will produce a clear error message directing the user to upgrade via v1.7 first.