ingestion-client: add stress tests#4911
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a15c9f65bf
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| use bytes::{Buf, BufMut, Bytes, BytesMut}; | ||
| use futures::{StreamExt, stream::FuturesUnordered}; | ||
| use rand::{Rng, SeedableRng, rngs::SmallRng}; |
There was a problem hiding this comment.
Building this package's test targets now pulls in stress_test.rs, but this import uses rand::rngs::SmallRng while the new dev-dependency is declared only as rand = { workspace = true } in crates/ingestion-client/Cargo.toml:32, and the workspace dependency is a plain rand = "0.9.3" in Cargo.toml:224. SmallRng is gated behind rand's small_rng feature, so the ignored stress test cannot be compiled or run until that feature is enabled here or a default-enabled RNG is used.
Useful? React with 👍 / 👎.
muhamadazmy
force-pushed
the
pr4911
branch
3 times, most recently
from
36488ab to
de92d06
Compare
Summary: This to make sure RPC related error or un handled status are visible in the logs
Summary: The tests are ignored by default but can be ran manually like ``` INGEST_STRESS_RECORDS=5000000 cargo nextest run -p restate-ingestion-client --run-ignored all ingest_exactly_once_under_leadership_churn ```
1 participant
Summary:
The tests are ignored by default but can be ran manually
like
Stack created with Sapling. Best reviewed with ReviewStack.