-
Notifications
You must be signed in to change notification settings - Fork 156
Introduce restate-platform foundation crate #4626
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -8,10 +8,9 @@ | |
| // the Business Source License, use of this software will be governed | ||
| // by the Apache License, Version 2.0. | ||
|
|
||
| use std::collections::HashMap; | ||
|
|
||
| use restate_encoding::NetSerde; | ||
| use static_assertions::assert_impl_all; | ||
| use restate_platform::hash::HashMap; | ||
| use restate_platform::network::NetSerde; | ||
|
|
||
| #[allow(dead_code)] | ||
| #[derive(NetSerde)] | ||
|
|
@@ -30,4 +29,7 @@ struct NotSendable; | |
| #[derive(NetSerde)] | ||
| struct Inner(HashMap<u64, String>); | ||
|
|
||
| assert_impl_all!(SomeMessage: NetSerde); | ||
| const _: fn() = || { | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Before we usually used
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is just the macro expansion as is. No strong opinion, just wanted to remove the dependency. |
||
| fn assert_impl_all<T: ?Sized + NetSerde>() {} | ||
| assert_impl_all::<SomeMessage>(); | ||
| }; | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why was this test removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(1) The test was added a couple of commits ago to prove wire compatibility, we don't really need to maintain it in the long run. (2) it was removed because restate-encoding doesn't really need to depend on
restate-sharding.