Use cargo hakari to automate workspace-hack #2472
Conversation
| @@ -0,0 +1,2 @@ | |||
| // A build script is required for cargo to consider build dependencies. | |||
There was a problem hiding this comment.
Shouldn't this also include the license header?
There was a problem hiding this comment.
It's an empty file that must remain empty. I don't think license header adds any value to that.
| @@ -0,0 +1 @@ | |||
| // This is a stub lib.rs. | |||
This PR integrates workspace-hack (via [cargo hakari](https://crates.io/crates/cargo-hakari)), this fixes the huge space amplification that we had with rocksdb builds, and it building/checking individual crates becomes significantly faster after the initial build. The cost of this: - Slightly longer initial build time (but I didn't really notice much difference on my machine) - I removed io-uring optional feature (easy to add back when we decide to give it another try) from rocksdb - After adding new third-party dependencies, make sure you run `cargo hakari generate`, don't worry, CI will catch if you didn't. This is a non-destructive change, and running with `cargo hakari` disable should still work if this is needed.
|
This is great, @AhmedSoliman! Works great for me as well. On my machine, Compared to I noticed that unrelated to your change, we no longer need the special-case target dir for test targets in the just file, as switching between |
This PR integrates workspace-hack (via cargo hakari), this fixes the huge space amplification that we had with rocksdb builds, and it building/checking individual crates becomes significantly faster after the initial build.
The cost of this:
cargo hakari generate, don't worry, CI will catch if you didn't.This is a non-destructive change, and running with
cargo hakaridisable should still work if this is needed.