Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add default = true for highlight groups definition. #541

Merged
merged 2 commits into from
Mar 8, 2025

Conversation

xieyonn
Copy link
Contributor

@xieyonn xieyonn commented Mar 5, 2025

  1. Add default = true for highlight groups, allow user to custom style.
  2. Add descriptions for highlight groups in doc rest-nvim.txt.

1. Add `default = true` for highlight groups, allow user to custom style.
2. Add descriptions for highlight groups in doc `rest-nvim.txt`
Copy link
Contributor

@boltlessengineer boltlessengineer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!
Although your documentation looks completely fine, it will be removed when auto-generating the help pages. So we should put that inside lua codes.
You can do this with docgen command.

I will modify your PR if you are not familiar with nix in this weekend.

@xieyonn
Copy link
Contributor Author

xieyonn commented Mar 7, 2025

Thank you for your explaination!
I'm not familiar with nix, it will be great if you can help!

@boltlessengineer boltlessengineer merged commit 54ee52a into rest-nvim:main Mar 8, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants