feat: gstr export tool for 2a/2b#4502
Conversation
Not up to standards ⛔🔴 Issues
|
| Category | Results |
|---|---|
| ErrorProne | 2 high |
🟢 Metrics 422 complexity
Metric Results Complexity 422
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
Priyal208
changed the title
68f9dd8 to
6de98f2
Compare
| @@ -0,0 +1,16 @@ | |||
| // GST Return Export summary. The number cards (NumberCardManager) and table | |||
| }, | ||
|
|
||
| setup_actions(frm) { | ||
| frm.add_custom_button(__("Show Summary"), () => render_summary(frm)); |
There was a problem hiding this comment.
btn sequence / what should be primary
| frappe.throw(__("Select Company, GSTIN, GST Return and the period before syncing.")); | ||
| } | ||
|
|
||
| const { message } = await fetch_summary(frm); |
There was a problem hiding this comment.
gstr import log. can it be independent and used on change of period -> simple ux to suggest user some info is missing
| link.href = file_url; | ||
| link.download = file_name; | ||
| document.body.appendChild(link); | ||
| link.click(); | ||
| link.remove(); |
There was a problem hiding this comment.
something better..
-> what if user doesn't have permissions for the file / to view any file?
-> maybe a new API request in backend to get file content and trigger it's download
-> what permissions check will you do for this?
| return _ITC_REASON.get(value, "") | ||
|
|
||
|
|
||
| RAW_FIELDS_2B = { |
| const periods = data?.periods || []; | ||
| if (!periods.length) return render_summary_placeholder(frm); | ||
|
|
||
| const is_2b = gst_return === "GSTR-2B"; |
There was a problem hiding this comment.
split this for 2A / 2B. we need this for more returns
| checked: !p.synced, | ||
| label: `${format_period(p.period)} · ${ | ||
| p.synced | ||
| ? __("synced {0}", [frappe.datetime.str_to_user(p.last_updated_on)]) |
| gstin_info = frappe._dict( | ||
| gstin=response.gstin, | ||
| business_name=titlecase(business_name or ""), | ||
| legal_name=response.lgnm or "", |
|
|
||
|
|
||
| EXPORTERS = { | ||
| GSTR2AExporter.return_type: GSTR2AExporter, |
|
|
||
|
|
||
| def save_gstr_2a(gstin, return_period, json_data): | ||
| def save_gstr_2a(gstin, return_period, json_data, *, merge=False, empty_categories=None): |
There was a problem hiding this comment.
let's first fix this and keep it consistant.
2 participants
GST Return Export — Phase 1 (Sync GSTR-2A / 2B)
Adds a Desk tool to download GSTR-2A/2B from the GST portal and export it to Excel byte-for-byte identical to the portal's own file.
What it does
store_raw_return_data/get_raw_return_data) — the export is raw-replay, not a lossy re-derivation from GST Inward Supply.gstr_2_export.py) fills the bundled portal templates label-by-label (survives template shifts): 2B invoice-level with code expansion + the four ITC-summary sheets from the portal'sitcsumm; 2A item-level with per-invoice-Totalrows; ISD invoice/credit-note routing, TCS computed columns, Read me header. Multi-period exports merge sections and sumitcsumm.returns_export): per-period aggregation from GST Inward Supply and a section-first range summary with ITC buckets, for the tool's summary view.Testing
Screenshots