Automate RhMatcherWorkflow execution to eliminate manual intervention in advisory generation pipeline #74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in advisory generation pipeline Adds Kubernetes CronJob that runs RhMatcherWorkflow every 4 hours, completing the final manual step in the Rocky Linux advisory automation. Follows the same pattern as the existing apollo-rhworker PollRHCSAFAdvisoriesWorkflow CronJob.
elguero
approved these changes
Dec 11, 2025
elguero
left a comment
elguero
left a comment
There was a problem hiding this comment.
Looks sane to me.
Mustafa or Neil should double check.
NeilHanlon
approved these changes
Dec 18, 2025
Contributor
NeilHanlon
left a comment
NeilHanlon
left a comment
There was a problem hiding this comment.
This looks great overall, thanks very much @rockythorn ! Follows established patterns, best practices, and sidecar management integration pain I ran into.
A couple operational suggestions to discuss/work in (independent of this PR):
- Consider adding
concurrencyPolicy: Forbidto the CronJob spec -- since the wf has a 12 hour timeout per product, if a job takes >6h we may get overlapping executions leading to a resource exhaustion upstream somewhere (database/cpu) - Given the 12 hour activity timeout, we might want to monitor/profile the actual runtime and consider if the schedule needs adjustment. We can watch this post-deployment.
- Commit message says "every 4 hours" but the code says every 6. Minor nit for posterity so I can't be accused of missing anything ;)
LGTM! 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds Kubernetes CronJob that runs RhMatcherWorkflow every 6 hours, completing the final manual step in the Rocky Linux advisory automation. Follows the same pattern as the existing apollo-rhworker PollRHCSAFAdvisoriesWorkflow CronJob.