1341 category improvements

[dmijatovic]

Custom categories improvements

Closes #1341
Closes #1362
Closes #1365

Changes proposed in this pull request:

• Changed labels on input form of custom categories for organisation and community (image 1)
• Removed capitalization style for custom organisation and community categories (image 2)
• The selection popup shows both label and description during the selection (image 3)
• Implemented chip visual layout on software page, similar to project page (image 4)
• Fix failing tests
• Added search in add category modal for organisation and community. We search for (partial) value in short_name and name.

How to test:

• make start to build and generate test data
• enable communities in settings.json. You will need to refresh/reload page for changes to take effect
• login as rsd_admin to be able to define categories on all "instances"
• navigate to first organisation and create new categories. Confirm input form has "Label" and "Description" labels. Create some categories with "custom" capitalization like "eScience", "sTranGe CaSiNG"
• navigate to software/project and select some of new categories. Confirm that both label and description are shown during the selection. Try search option.
• view software and confirm selected categories are shown in the new layout (image 4)

Global custom categories (unchanged)

Input labels for categories on organisation and communities page

Removed capitalization from category chip

Select & search category (example)

Custom categories on software page

PR Checklist:

• Increase version numbers in docker-compose.yml
• Link to a GitHub issue
• Update documentation
• Tests

[cmeessen]

In the initial implementation "Name" was dedicated as full name, whereas "Short name" was the shortened form. It was not intended as a description, this would be a dedicated property. Thus, I strongly suggest to add a dedicated description field if this is required as this does not work with the use case we have already in production.

[bakhshir]

This looks good. And I agree with @cmeessen that we might be misusing the full name field as basically description field. But unfortunately, we need it this way. We can continue using full name field as description, if search functionality is implemented - it would be easier to search.

[dmijatovic]

@cmeessen and @bakhshir Thanks for you feedback!

The label change (Short name to Label and Name to Description) is change in the labels shown to user in the organisation and communities section only.

The working of "global" custom categories is not changed in order to avoid any impact on the Helmholtz categories implementation. The structure of the categories table remains unchanged. I assumed that Helmholtz use global categories only.

We seem to have slightly different use cases where different labels are more clear to users. In both cases we only need 2 inputs. Maybe we can use labeling that includes both labels?

• Short name / Label
• Full name / Description

Let me know what you think. Other suggestions/ideas are welcome. If you would like to discuss this PR in more details in person you are welcome to join our standup.

[dmijatovic]

@cmeessen and @bakhshir

I have made following changes on the category labels (see image 1 and 2 in the PR description)

• Global categories remains unchanged
• Categories for organisations and communities use original labels. Additional help text is added to clarify how values are used

Let me know what you think about this approach

[sonarqubecloud]

Quality Gate failed for 'rsd-frontend'

Failed conditions
3.8% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud