Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verbosity Flags & Better Error Output #126

Merged
merged 1 commit into from
Nov 15, 2024
Merged

Verbosity Flags & Better Error Output #126

merged 1 commit into from
Nov 15, 2024

Conversation

rolandpeelen
Copy link
Member

@rolandpeelen rolandpeelen commented Jun 26, 2024 •
edited
Loading

Screenshot 2024-11-15 at 10 29 23 PM

Enable -v -vv -q -qq -qqq with default being info. The progress info is completely shut off when in Off mode.

@rolandpeelen rolandpeelen requested a review from jfrolich June 26, 2024 18:02
@rolandpeelen
Copy link
Member Author

Should give you a fix for #113 -- @cknitt 🙌

@rolandpeelen rolandpeelen requested a review from cknitt June 26, 2024 18:03
@cknitt
Copy link
Member

cknitt commented Jun 26, 2024

Great! Thanks a lot!

Tests are failing though.

From the user experience point of view I think it would be nicer to have a command line option for the log level (or maybe even just a --quiet option) instead of having to set an environment variable called RUST_LOG.

@rolandpeelen rolandpeelen mentioned this pull request Oct 22, 2024
Closed
@rolandpeelen rolandpeelen force-pushed the issue/113 branch 3 times, most recently from 5d994e8 to 90f37c7 Compare November 15, 2024 21:08
@rolandpeelen rolandpeelen changed the title 🔊 - Move logging to env_logger Verbosity Flags & Better Error Output Nov 15, 2024
@rolandpeelen
🔊 - Move logging to env_logger
4c4d725 
This adds the ability to use log levels for CI. Running `RUST_LOG=warn
rewatch build` will only use `warn` and up.

See the [env_logger](https://docs.rs/env_logger/latest/env_logger/)
crate for more info.
@rolandpeelen
Copy link
Member Author

@cknitt -- It took me a while to get back to this. Life and all. But have another look please.

    /// Verbosity:
    /// -v -> Debug
    /// -vv -> Trace
    /// -q -> Warn
    /// -qq -> Error 
    /// -qqq -> Off. 
    /// Default (/ no argument given): 'info'

@rolandpeelen rolandpeelen merged commit 8c1fa02 into master Nov 15, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfrolich jfrolich Awaiting requested review from jfrolich

@cknitt cknitt Awaiting requested review from cknitt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rolandpeelen @cknitt