Change snakecase to camelcase for prop

[nojaf]

Fixes #7451

[cknitt]

According to the React docs, ARIA attributes should be snake case, not camel case.

See https://react.dev/reference/react-dom/components/common#common-props

In React, all ARIA attribute names are exactly the same as in HTML.

The correct JSX output should be

<label aria-label={"close sidebar"} />

So IMHO the fix should just be to remove the double quotes around the prop name.

[nojaf]

Interesting, I didn't know area labels were an exception here.
I'll update the code to just remove the quotes.

[zth]

Actually, I think the right thing is just to never escape/add quotes to the prop name. Any prop name can use -.

[nojaf]

The check added #7429 might not have been the best fit. I've addressed it.

[pkg-pr-new]

Open in StackBlitz

rescript

npm i https://pkg.pr.new/rescript-lang/rescript@7460

@rescript/darwin-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/darwin-x64@7460

@rescript/linux-arm64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/linux-arm64@7460

@rescript/darwin-arm64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/darwin-arm64@7460

@rescript/linux-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/linux-x64@7460

@rescript/win32-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/win32-x64@7460

commit: be40265

[cknitt]

Looks good to me now! Thanks!