@notUndefined attribute for abstract types

[cknitt]

Implement an attribute for abstract types which is a cleaner solution than the

type t = private {}

hack.

[pkg-pr-new]

Open in StackBlitz

rescript

npm i https://pkg.pr.new/rescript-lang/rescript@7458

@rescript/darwin-arm64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/darwin-arm64@7458

@rescript/linux-arm64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/linux-arm64@7458

@rescript/darwin-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/darwin-x64@7458

@rescript/linux-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/linux-x64@7458

@rescript/win32-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/win32-x64@7458

commit: cc8754e

[zth]

Awesome! Could you also raise an error when it's used on a non-abstract type?

[zth]

Should probably also add it to the editor tooling in the decorators file.

[cknitt]

@zth Done!

[zth]

@cristianoc any thoughts?

[cristianoc]

Looks good.
Are we happy about the name?
Nit: perhaps define the string constant separately to avoid repeating it in the code.
Would we support the lowercase version too, or rely on the camel case version spelling to be correct?

[cknitt]

Nit: perhaps define the string constant separately to avoid repeating it in the code.

Done (extracted helper function).

Would we support the lowercase version too, or rely on the camel case version spelling to be correct?

I feel it is ok to rely on correct camel case spelling.

[cristianoc]

merge away!