fix: handle dynamic imports with module aliases #7452
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #7403 When a module containing an alias (e.g. `module VS = VariantSpreads`) is dynamically imported, the compiler now correctly extracts the original module identifier from the Llet expression.
cristianoc
force-pushed
the
dynamic-import-module-with-alias
branch
from
cc6459e to
cf92334
Compare
cristianoc
commented
May 9, 2025
| @@ -442,6 +442,22 @@ let convert (exports : Set_ident.t) (lam : Lambda.lambda) : | |||
| in | |||
| Lam.function_ ~attr ~arity:(List.length params) ~params | |||
| ~body:(convert_aux body) | |||
| | Llet (_, _, _, Lprim (Pgetglobal id, args, _), _body) when dynamic_import | |||
There was a problem hiding this comment.
@mununki is this the correct way to handle the case?
cknitt
approved these changes
May 12, 2025
rescript
@rescript/darwin-arm64
@rescript/darwin-x64
@rescript/linux-arm64
@rescript/linux-x64
@rescript/win32-x64
commit: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7403
When a module containing an alias (e.g.
module VS = VariantSpreads) is dynamically imported, the compiler now correctly extracts the original module identifier from the Llet expression.