Make Jsx.element a private empty record to avoid unnecessary Primitive_option.some #7450
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cknitt
force-pushed
the
jsx-element-private-empty-record
branch
from
e36f9ff to
0b93205
Compare
rescript
@rescript/darwin-x64
@rescript/linux-x64
@rescript/linux-arm64
@rescript/win32-x64
@rescript/darwin-arm64
commit: |
|
Also tested successfully against a real-world project. Goodbye, |
nojaf
reviewed
May 9, 2025
cknitt
force-pushed
the
jsx-element-private-empty-record
branch
from
ed244b0 to
af98928
Compare
nojaf
approved these changes
May 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement @glennsl's idea from #7430 (comment)
(And update the ancient React bindings in the tests.)